Skip to content

Commit 70c233c

Browse files
authored
chore: update node-forge to ^0.9.1 (#941)
As commnented on #934 (comment) Given that node-forge is a 0.x version, npm considers it to be a breaking change, and hence not compatible with the current requirement. node-forge is also transitively being used by firestore (direct dependency is google-p12-pem), and requiring version ^0.9.0, which means two copies of the library are currently needed. Switching to just one dependency would save 1.7Mib.
1 parent 1b283e3 commit 70c233c

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

package-lock.json

Lines changed: 3 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"@types/node": "^10.10.0",
5959
"dicer": "^0.3.0",
6060
"jsonwebtoken": "^8.5.1",
61-
"node-forge": "^0.7.6"
61+
"node-forge": "^0.9.1"
6262
},
6363
"optionalDependencies": {
6464
"@google-cloud/firestore": "^4.0.0",

0 commit comments

Comments
 (0)