Skip to content

Commit 89d7244

Browse files
committed
address tech review feedback (#1685)
1 parent d3f68e9 commit 89d7244

File tree

4 files changed

+26
-30
lines changed

4 files changed

+26
-30
lines changed

src/auth/auth-config.ts

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,19 +1722,18 @@ export class SmsRegionsAuthConfig {
17221722
}
17231723
}
17241724
}
1725-
17261725
/**
1727-
* Enforcement state of reCAPTCHA protection.
1728-
* - 'OFF': Unenforced.
1729-
* - 'AUDIT': Assessment is created but result is not used to enforce.
1730-
* - 'ENFORCE': Assessment is created and result is used to enforce.
1731-
*/
1726+
* Enforcement state of reCAPTCHA protection.
1727+
* - 'OFF': Unenforced.
1728+
* - 'AUDIT': Create assessment but don't enforce the result.
1729+
* - 'ENFORCE': Create assessment and enforce the result.
1730+
*/
17321731
export type RecaptchaProviderEnforcementState = 'OFF' | 'AUDIT' | 'ENFORCE';
17331732

17341733
/**
1735-
* The actions for reCAPTCHA-protected requests.
1736-
* - 'BLOCK': The reCAPTCHA-protected request will be blocked.
1737-
*/
1734+
* The actions to take for reCAPTCHA-protected requests.
1735+
* - 'BLOCK': The reCAPTCHA-protected request will be blocked.
1736+
*/
17381737
export type RecaptchaAction = 'BLOCK';
17391738

17401739
/**
@@ -1752,7 +1751,7 @@ export interface RecaptchaManagedRule {
17521751
}
17531752

17541753
/**
1755-
* The key's platform type: only web supported now.
1754+
* The key's platform type: only web is currently supported.
17561755
*/
17571756
export type RecaptchaKeyClientType = 'WEB';
17581757

@@ -1779,7 +1778,7 @@ export interface RecaptchaKey {
17791778
*/
17801779
export interface RecaptchaConfig {
17811780
/**
1782-
* The enforcement state of email password provider.
1781+
* The enforcement state of the email password provider.
17831782
*/
17841783
emailPasswordEnforcementState?: RecaptchaProviderEnforcementState;
17851784
/**

src/auth/project-config-manager.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ import {
2020
} from './auth-api-request';
2121

2222
/**
23-
* Defines the project config manager used to help manage project config related operations.
24-
* This includes:
25-
* <ul>
26-
* <li>The ability to update and get project config.</li>
23+
* Manages (gets and updates) the current project config.
2724
*/
2825
export class ProjectConfigManager {
2926
private readonly authRequestHandler: AuthRequestHandler;

src/auth/project-config.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,19 @@ export interface UpdateProjectConfigRequest {
3838
* The multi-factor auth configuration to update on the project.
3939
*/
4040
multiFactorConfig?: MultiFactorConfig;
41-
41+
4242
/**
43-
* The recaptcha configuration to update on the project.
44-
* By enabling reCAPTCHA Enterprise Integration you are
45-
* agreeing to reCAPTCHA Enterprise
43+
* The reCAPTCHA configuration to update on the project.
44+
* By enabling reCAPTCHA Enterprise integration, you are
45+
* agreeing to the reCAPTCHA Enterprise
4646
* {@link https://cloud.google.com/terms/service-terms | Term of Service}.
4747
*/
4848
recaptchaConfig?: RecaptchaConfig;
4949
}
5050

5151
/**
52-
* Response received from getting or updating a project config.
53-
* This object currently exposes only the SMS Region config.
52+
* Response received when getting or updating the project config.
53+
* Currently only includes the reCAPTCHA and SMS Region config.
5454
*/
5555
export interface ProjectConfigServerResponse {
5656
smsRegionConfig?: SmsRegionConfig;
@@ -59,8 +59,8 @@ export interface ProjectConfigServerResponse {
5959
}
6060

6161
/**
62-
* Request sent to update project config.
63-
* This object currently exposes only the SMS Region config.
62+
* Request to update the project config.
63+
* Currently only includes the reCAPTCHA and SMS Region config.
6464
*/
6565
export interface ProjectConfigClientRequest {
6666
smsRegionConfig?: SmsRegionConfig;
@@ -86,9 +86,9 @@ export class ProjectConfig {
8686
private readonly multiFactorConfig_?: MultiFactorConfig;
8787

8888
/**
89-
* The recaptcha configuration to update on the project config.
90-
* By enabling reCAPTCHA Enterprise Integration you are
91-
* agreeing to reCAPTCHA Enterprise
89+
* The reCAPTCHA configuration to update on the project.
90+
* By enabling reCAPTCHA Enterprise integration, you are
91+
* agreeing to the reCAPTCHA Enterprise
9292
* {@link https://cloud.google.com/terms/service-terms | Term of Service}.
9393
*/
9494
private readonly recaptchaConfig_?: RecaptchaAuthConfig;
@@ -163,7 +163,7 @@ export class ProjectConfig {
163163
}
164164

165165
/**
166-
* The recaptcha configuration.
166+
* The reCAPTCHA configuration.
167167
*/
168168
get recaptchaConfig(): RecaptchaConfig | undefined {
169169
return this.recaptchaConfig_;

src/auth/tenant.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ export interface UpdateTenantRequest {
6161
smsRegionConfig?: SmsRegionConfig;
6262

6363
/**
64-
* The recaptcha configuration to update on the tenant.
65-
* By enabling reCAPTCHA Enterprise Integration you are
66-
* agreeing to reCAPTCHA Enterprise
64+
* The reCAPTCHA configuration to update on the tenant.
65+
* By enabling reCAPTCHA Enterprise integration, you are
66+
* agreeing to the reCAPTCHA Enterprise
6767
* {@link https://cloud.google.com/terms/service-terms | Term of Service}.
6868
*/
6969
recaptchaConfig?: RecaptchaConfig;

0 commit comments

Comments
 (0)