Skip to content

Commit bed1e5e

Browse files
authored
fix(auth): Add interfaces for UserProviderRequest and Metadata used in UserImportRecord (#909)
* fix: Add interface for UserProviderRequest used for ProviderData * Add similar fix for metadata * Remove lastRefreshTime from UserMetadataRequest * Remove lastRefreshTime from UserMetadataRequest typing * Remove lastRefreshTime field from object in test
1 parent 79e61ed commit bed1e5e

File tree

3 files changed

+15
-19
lines changed

3 files changed

+15
-19
lines changed

src/auth.d.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -704,13 +704,6 @@ export namespace admin.auth {
704704
* The date the user was created, formatted as a UTC string.
705705
*/
706706
creationTime?: string;
707-
708-
/**
709-
* The time at which the user was last active (ID token refreshed),
710-
* formatted as a UTC Date string (eg 'Sat, 03 Feb 2001 04:05:06 GMT').
711-
* Null implies the user was never active.
712-
*/
713-
lastRefreshTime?: string|null;
714707
}
715708

716709
/**

src/auth/user-import-builder.ts

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,19 @@ interface SecondFactor {
4747
factorId: string;
4848
}
4949

50+
interface UserProviderRequest {
51+
uid: string;
52+
displayName?: string;
53+
email?: string;
54+
phoneNumber?: string;
55+
photoURL?: string;
56+
providerId: string;
57+
}
58+
59+
interface UserMetadataRequest {
60+
lastSignInTime?: string;
61+
creationTime?: string;
62+
}
5063

5164
/** User import record as accepted from developer. */
5265
export interface UserImportRecord {
@@ -57,17 +70,8 @@ export interface UserImportRecord {
5770
phoneNumber?: string;
5871
photoURL?: string;
5972
disabled?: boolean;
60-
metadata?: {
61-
lastSignInTime?: string;
62-
creationTime?: string;
63-
};
64-
providerData?: Array<{
65-
uid: string;
66-
displayName?: string;
67-
email?: string;
68-
photoURL?: string;
69-
providerId: string;
70-
}>;
73+
metadata?: UserMetadataRequest;
74+
providerData?: Array<UserProviderRequest>;
7175
multiFactor?: {
7276
enrolledFactors: SecondFactor[];
7377
};

test/integration/auth.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ describe('admin.auth', () => {
239239
metadata: {
240240
lastSignInTime: 'Thu, 01 Jan 1970 00:00:00 UTC',
241241
creationTime: 'Thu, 01 Jan 1970 00:00:00 UTC',
242-
lastRefreshTime: null,
243242
},
244243
providerData: [{
245244
displayName: 'User Four',

0 commit comments

Comments
 (0)