Skip to content

Commit d0ffb56

Browse files
committed
Fix rollback tests
1 parent 3216fd3 commit d0ffb56

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

test/integration/remote-config.spec.ts

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -163,46 +163,46 @@ describe('admin.remoteConfig', () => {
163163
});
164164
});
165165

166-
let firstVersionNumber: string;
167-
let secondVersionNumber: string;
168-
const versionDescription1 = `getTemplateAtVersion test v1 ${Date.now()}`;
169-
const versionDescription2 = `getTemplateAtVersion test v2 ${Date.now()}`;
166+
let versionOneNumber: string;
167+
let versionTwoNumber: string;
168+
const versionOneDescription = `getTemplateAtVersion test v1 ${Date.now()}`;
169+
const versionTwoDescription = `getTemplateAtVersion test v2 ${Date.now()}`;
170170

171171
describe('getTemplateAtVersion', () => {
172172
before(async () => {
173173
// obtain the current active template
174174
let activeTemplate = await admin.remoteConfig().getTemplate();
175175

176176
// publish a new template to create a new version number
177-
activeTemplate.version = { description: versionDescription1 };
177+
activeTemplate.version = { description: versionOneDescription };
178178
activeTemplate = await admin.remoteConfig().publishTemplate(activeTemplate)
179179
expect(activeTemplate.version).to.be.not.undefined;
180-
firstVersionNumber = activeTemplate.version!.versionNumber!;
180+
versionOneNumber = activeTemplate.version!.versionNumber!;
181181

182182
// publish another template to create a second version number
183-
activeTemplate.version = { description: versionDescription2 };
183+
activeTemplate.version = { description: versionTwoDescription };
184184
activeTemplate = await admin.remoteConfig().publishTemplate(activeTemplate)
185185
expect(activeTemplate.version).to.be.not.undefined;
186-
secondVersionNumber = activeTemplate.version!.versionNumber!;
186+
versionTwoNumber = activeTemplate.version!.versionNumber!;
187187
});
188188

189189
it('verfy that getTemplateAtVersion() returns the requested template version v1', () => {
190-
return admin.remoteConfig().getTemplateAtVersion(firstVersionNumber)
190+
return admin.remoteConfig().getTemplateAtVersion(versionOneNumber)
191191
.then((template) => {
192192
expect(template.etag).matches(/^etag-[0-9]*-[0-9]*$/);
193193
expect(template.version).to.be.not.undefined;
194-
expect(template.version!.versionNumber).equals(firstVersionNumber);
195-
expect(template.version!.description).equals(versionDescription1);
194+
expect(template.version!.versionNumber).equals(versionOneNumber);
195+
expect(template.version!.description).equals(versionOneDescription);
196196
});
197197
});
198198

199199
it('verfy that getTemplateAtVersion() returns the requested template version v2', () => {
200-
return admin.remoteConfig().getTemplateAtVersion(secondVersionNumber)
200+
return admin.remoteConfig().getTemplateAtVersion(versionTwoNumber)
201201
.then((template) => {
202202
expect(template.etag).matches(/^etag-[0-9]*-[0-9]*$/);
203203
expect(template.version).to.be.not.undefined;
204-
expect(template.version!.versionNumber).equals(secondVersionNumber);
205-
expect(template.version!.description).equals(versionDescription2);
204+
expect(template.version!.versionNumber).equals(versionTwoNumber);
205+
expect(template.version!.description).equals(versionTwoDescription);
206206
});
207207
});
208208
});
@@ -215,10 +215,10 @@ describe('admin.remoteConfig', () => {
215215
.then((response) => {
216216
expect(response.versions.length).to.equal(2);
217217
// versions should be in reverse chronological order
218-
expect(response.versions[0].description).equals(versionDescription2);
219-
expect(response.versions[0].versionNumber).equals(secondVersionNumber);
220-
expect(response.versions[1].description).equals(versionDescription1);
221-
expect(response.versions[1].versionNumber).equals(firstVersionNumber);
218+
expect(response.versions[0].description).equals(versionTwoDescription);
219+
expect(response.versions[0].versionNumber).equals(versionTwoNumber);
220+
expect(response.versions[1].description).equals(versionOneDescription);
221+
expect(response.versions[1].versionNumber).equals(versionOneNumber);
222222
});
223223
});
224224
});
@@ -228,16 +228,16 @@ describe('admin.remoteConfig', () => {
228228
return admin.remoteConfig().getTemplate()
229229
.then((template) => {
230230
expect(template.version).to.be.not.undefined;
231-
expect(template.version!.versionNumber).equals(secondVersionNumber);
231+
expect(template.version!.versionNumber).equals(versionTwoNumber);
232232
});
233233
});
234234

235235
it('should rollback to the requested version', () => {
236-
return admin.remoteConfig().rollback('2')
236+
return admin.remoteConfig().rollback(versionOneNumber)
237237
.then((template) => {
238238
expect(template.version).to.be.not.undefined;
239-
expect(template.version!.versionNumber).equals(firstVersionNumber);
240-
expect(template.version!.description).equals(`Rollback to version ${firstVersionNumber}`);
239+
expect(template.version!.updateType).equals('ROLLBACK');
240+
expect(template.version!.description).equals(`Rollback to version ${versionOneNumber}`);
241241
});
242242
});
243243
});

0 commit comments

Comments
 (0)