@@ -163,46 +163,46 @@ describe('admin.remoteConfig', () => {
163
163
} ) ;
164
164
} ) ;
165
165
166
- let firstVersionNumber : string ;
167
- let secondVersionNumber : string ;
168
- const versionDescription1 = `getTemplateAtVersion test v1 ${ Date . now ( ) } ` ;
169
- const versionDescription2 = `getTemplateAtVersion test v2 ${ Date . now ( ) } ` ;
166
+ let versionOneNumber : string ;
167
+ let versionTwoNumber : string ;
168
+ const versionOneDescription = `getTemplateAtVersion test v1 ${ Date . now ( ) } ` ;
169
+ const versionTwoDescription = `getTemplateAtVersion test v2 ${ Date . now ( ) } ` ;
170
170
171
171
describe ( 'getTemplateAtVersion' , ( ) => {
172
172
before ( async ( ) => {
173
173
// obtain the current active template
174
174
let activeTemplate = await admin . remoteConfig ( ) . getTemplate ( ) ;
175
175
176
176
// publish a new template to create a new version number
177
- activeTemplate . version = { description : versionDescription1 } ;
177
+ activeTemplate . version = { description : versionOneDescription } ;
178
178
activeTemplate = await admin . remoteConfig ( ) . publishTemplate ( activeTemplate )
179
179
expect ( activeTemplate . version ) . to . be . not . undefined ;
180
- firstVersionNumber = activeTemplate . version ! . versionNumber ! ;
180
+ versionOneNumber = activeTemplate . version ! . versionNumber ! ;
181
181
182
182
// publish another template to create a second version number
183
- activeTemplate . version = { description : versionDescription2 } ;
183
+ activeTemplate . version = { description : versionTwoDescription } ;
184
184
activeTemplate = await admin . remoteConfig ( ) . publishTemplate ( activeTemplate )
185
185
expect ( activeTemplate . version ) . to . be . not . undefined ;
186
- secondVersionNumber = activeTemplate . version ! . versionNumber ! ;
186
+ versionTwoNumber = activeTemplate . version ! . versionNumber ! ;
187
187
} ) ;
188
188
189
189
it ( 'verfy that getTemplateAtVersion() returns the requested template version v1' , ( ) => {
190
- return admin . remoteConfig ( ) . getTemplateAtVersion ( firstVersionNumber )
190
+ return admin . remoteConfig ( ) . getTemplateAtVersion ( versionOneNumber )
191
191
. then ( ( template ) => {
192
192
expect ( template . etag ) . matches ( / ^ e t a g - [ 0 - 9 ] * - [ 0 - 9 ] * $ / ) ;
193
193
expect ( template . version ) . to . be . not . undefined ;
194
- expect ( template . version ! . versionNumber ) . equals ( firstVersionNumber ) ;
195
- expect ( template . version ! . description ) . equals ( versionDescription1 ) ;
194
+ expect ( template . version ! . versionNumber ) . equals ( versionOneNumber ) ;
195
+ expect ( template . version ! . description ) . equals ( versionOneDescription ) ;
196
196
} ) ;
197
197
} ) ;
198
198
199
199
it ( 'verfy that getTemplateAtVersion() returns the requested template version v2' , ( ) => {
200
- return admin . remoteConfig ( ) . getTemplateAtVersion ( secondVersionNumber )
200
+ return admin . remoteConfig ( ) . getTemplateAtVersion ( versionTwoNumber )
201
201
. then ( ( template ) => {
202
202
expect ( template . etag ) . matches ( / ^ e t a g - [ 0 - 9 ] * - [ 0 - 9 ] * $ / ) ;
203
203
expect ( template . version ) . to . be . not . undefined ;
204
- expect ( template . version ! . versionNumber ) . equals ( secondVersionNumber ) ;
205
- expect ( template . version ! . description ) . equals ( versionDescription2 ) ;
204
+ expect ( template . version ! . versionNumber ) . equals ( versionTwoNumber ) ;
205
+ expect ( template . version ! . description ) . equals ( versionTwoDescription ) ;
206
206
} ) ;
207
207
} ) ;
208
208
} ) ;
@@ -215,10 +215,10 @@ describe('admin.remoteConfig', () => {
215
215
. then ( ( response ) => {
216
216
expect ( response . versions . length ) . to . equal ( 2 ) ;
217
217
// versions should be in reverse chronological order
218
- expect ( response . versions [ 0 ] . description ) . equals ( versionDescription2 ) ;
219
- expect ( response . versions [ 0 ] . versionNumber ) . equals ( secondVersionNumber ) ;
220
- expect ( response . versions [ 1 ] . description ) . equals ( versionDescription1 ) ;
221
- expect ( response . versions [ 1 ] . versionNumber ) . equals ( firstVersionNumber ) ;
218
+ expect ( response . versions [ 0 ] . description ) . equals ( versionTwoDescription ) ;
219
+ expect ( response . versions [ 0 ] . versionNumber ) . equals ( versionTwoNumber ) ;
220
+ expect ( response . versions [ 1 ] . description ) . equals ( versionOneDescription ) ;
221
+ expect ( response . versions [ 1 ] . versionNumber ) . equals ( versionOneNumber ) ;
222
222
} ) ;
223
223
} ) ;
224
224
} ) ;
@@ -228,16 +228,16 @@ describe('admin.remoteConfig', () => {
228
228
return admin . remoteConfig ( ) . getTemplate ( )
229
229
. then ( ( template ) => {
230
230
expect ( template . version ) . to . be . not . undefined ;
231
- expect ( template . version ! . versionNumber ) . equals ( secondVersionNumber ) ;
231
+ expect ( template . version ! . versionNumber ) . equals ( versionTwoNumber ) ;
232
232
} ) ;
233
233
} ) ;
234
234
235
235
it ( 'should rollback to the requested version' , ( ) => {
236
- return admin . remoteConfig ( ) . rollback ( '2' )
236
+ return admin . remoteConfig ( ) . rollback ( versionOneNumber )
237
237
. then ( ( template ) => {
238
238
expect ( template . version ) . to . be . not . undefined ;
239
- expect ( template . version ! . versionNumber ) . equals ( firstVersionNumber ) ;
240
- expect ( template . version ! . description ) . equals ( `Rollback to version ${ firstVersionNumber } ` ) ;
239
+ expect ( template . version ! . updateType ) . equals ( 'ROLLBACK' ) ;
240
+ expect ( template . version ! . description ) . equals ( `Rollback to version ${ versionOneNumber } ` ) ;
241
241
} ) ;
242
242
} ) ;
243
243
} ) ;
0 commit comments