Skip to content

Commit d979c1c

Browse files
address tech review feedback (#1685)
1 parent 583f9e0 commit d979c1c

File tree

4 files changed

+20
-23
lines changed

4 files changed

+20
-23
lines changed

src/auth/auth-config.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1455,13 +1455,13 @@ export class OIDCConfig implements OIDCAuthProviderConfig {
14551455
/**
14561456
* Enforcement state of reCAPTCHA protection.
14571457
* - 'OFF': Unenforced.
1458-
* - 'AUDIT': Assessment is created but result is not used to enforce.
1459-
* - 'ENFORCE': Assessment is created and result is used to enforce.
1458+
* - 'AUDIT': Create assessment but don't enforce the result.
1459+
* - 'ENFORCE': Create assessment and enforce the result.
14601460
*/
14611461
export type RecaptchaProviderEnforcementState = 'OFF' | 'AUDIT' | 'ENFORCE';
14621462

14631463
/**
1464-
* The actions for reCAPTCHA-protected requests.
1464+
* The actions to take for reCAPTCHA-protected requests.
14651465
* - 'BLOCK': The reCAPTCHA-protected request will be blocked.
14661466
*/
14671467
export type RecaptchaAction = 'BLOCK';
@@ -1481,7 +1481,7 @@ export interface RecaptchaManagedRule {
14811481
}
14821482

14831483
/**
1484-
* The key's platform type: only web supported now.
1484+
* The key's platform type: only web is currently supported.
14851485
*/
14861486
export type RecaptchaKeyClientType = 'WEB';
14871487

@@ -1508,7 +1508,7 @@ export interface RecaptchaKey {
15081508
*/
15091509
export interface RecaptchaConfig {
15101510
/**
1511-
* The enforcement state of email password provider.
1511+
* The enforcement state of the email password provider.
15121512
*/
15131513
emailPasswordEnforcementState?: RecaptchaProviderEnforcementState;
15141514
/**

src/auth/project-config-manager.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ import {
2020
} from './auth-api-request';
2121

2222
/**
23-
* Defines the project config manager used to help manage project config related operations.
24-
* This includes:
25-
* <ul>
26-
* <li>The ability to update and get project config.</li>
23+
* Manages (gets and updates) the current project config.
2724
*/
2825
export class ProjectConfigManager {
2926
private readonly authRequestHandler: AuthRequestHandler;

src/auth/project-config.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,25 @@ import {
2525
*/
2626
export interface UpdateProjectConfigRequest {
2727
/**
28-
* The recaptcha configuration to update on the project.
29-
* By enabling reCAPTCHA Enterprise Integration you are
30-
* agreeing to reCAPTCHA Enterprise
28+
* The reCAPTCHA configuration to update on the project.
29+
* By enabling reCAPTCHA Enterprise integration, you are
30+
* agreeing to the reCAPTCHA Enterprise
3131
* {@link https://cloud.google.com/terms/service-terms | Term of Service}.
3232
*/
3333
recaptchaConfig?: RecaptchaConfig;
3434
}
3535

3636
/**
37-
* Response received from get/update project config.
38-
* We are only exposing the recaptcha config for now.
37+
* Response received when getting or updating the project config.
38+
* Currently only includes the reCAPTCHA config.
3939
*/
4040
export interface ProjectConfigServerResponse {
4141
recaptchaConfig?: RecaptchaConfig;
4242
}
4343

4444
/**
45-
* Request sent to update project config.
46-
* We are only updating the recaptcha config for now.
45+
* Request to update the project config.
46+
* Currently only includes the reCAPTCHA config.
4747
*/
4848
export interface ProjectConfigClientRequest {
4949
recaptchaConfig?: RecaptchaConfig;
@@ -54,9 +54,9 @@ export interface ProjectConfigClientRequest {
5454
*/
5555
export class ProjectConfig {
5656
/**
57-
* The recaptcha configuration to update on the project config.
58-
* By enabling reCAPTCHA Enterprise Integration you are
59-
* agreeing to reCAPTCHA Enterprise
57+
* The reCAPTCHA configuration to update on the project.
58+
* By enabling reCAPTCHA Enterprise integration, you are
59+
* agreeing to the reCAPTCHA Enterprise
6060
* {@link https://cloud.google.com/terms/service-terms | Term of Service}.
6161
*/
6262
private readonly recaptchaConfig_?: RecaptchaAuthConfig;
@@ -103,7 +103,7 @@ export class ProjectConfig {
103103
}
104104

105105
/**
106-
* The recaptcha configuration.
106+
* The reCAPTCHA configuration.
107107
*/
108108
get recaptchaConfig(): RecaptchaConfig | undefined {
109109
return this.recaptchaConfig_;

src/auth/tenant.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ export interface UpdateTenantRequest {
5656
testPhoneNumbers?: { [phoneNumber: string]: string } | null;
5757

5858
/**
59-
* The recaptcha configuration to update on the tenant.
60-
* By enabling reCAPTCHA Enterprise Integration you are
61-
* agreeing to reCAPTCHA Enterprise
59+
* The reCAPTCHA configuration to update on the tenant.
60+
* By enabling reCAPTCHA Enterprise integration, you are
61+
* agreeing to the reCAPTCHA Enterprise
6262
* {@link https://cloud.google.com/terms/service-terms | Term of Service}.
6363
*/
6464
recaptchaConfig?: RecaptchaConfig;

0 commit comments

Comments
 (0)