From cb6fe63651c2a9c61c341fb8415d69d2854a7cbc Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Thu, 22 Sep 2022 15:39:45 -0400 Subject: [PATCH 1/3] Drop support for Python 3.6 --- .github/workflows/ci.yml | 10 +++++----- .github/workflows/nightly.yml | 6 +++--- .github/workflows/release.yml | 4 ++-- setup.py | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0ae8f6585..e90c0cd59 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,12 +8,12 @@ jobs: strategy: fail-fast: false matrix: - python: [3.6, 3.7, 3.8, 3.9, pypy3] + python: [3.7, 3.8, 3.9, 3.10, pypy3.7] steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v3 - name: Set up Python ${{ matrix.python }} - uses: actions/setup-python@v1 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python }} - name: Install dependencies @@ -34,9 +34,9 @@ jobs: lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v3 - name: Set up Python 3.7 - uses: actions/setup-python@v1 + uses: actions/setup-python@v4 with: python-version: 3.7 - name: Install dependencies diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index f22eb99c8..ac6c62abe 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -29,14 +29,14 @@ jobs: steps: - name: Checkout source for staging - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ github.event.client_payload.ref || github.ref }} - name: Set up Python - uses: actions/setup-python@v1 + uses: actions/setup-python@v4 with: - python-version: 3.6 + python-version: 3.7 - name: Install dependencies run: | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fbde8ed59..5eb4bfaea 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -45,9 +45,9 @@ jobs: ref: ${{ github.event.client_payload.ref || github.ref }} - name: Set up Python - uses: actions/setup-python@v1 + uses: actions/setup-python@v4 with: - python-version: 3.6 + python-version: 3.7 - name: Install dependencies run: | diff --git a/setup.py b/setup.py index 282c3aa59..a54949891 100644 --- a/setup.py +++ b/setup.py @@ -22,8 +22,8 @@ (major, minor) = (sys.version_info.major, sys.version_info.minor) -if major != 3 or minor < 6: - print('firebase_admin requires python >= 3.6', file=sys.stderr) +if major != 3 or minor < 7: + print('firebase_admin requires python >= 3.7', file=sys.stderr) sys.exit(1) # Read in the package metadata per recommendations from: @@ -58,16 +58,16 @@ keywords='firebase cloud development', install_requires=install_requires, packages=['firebase_admin'], - python_requires='>=3.6', + python_requires='>=3.7', classifiers=[ 'Development Status :: 5 - Production/Stable', 'Intended Audience :: Developers', 'Topic :: Software Development :: Build Tools', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', 'Programming Language :: Python :: 3.8', 'Programming Language :: Python :: 3.9', + 'Programming Language :: Python :: 3.10', 'License :: OSI Approved :: Apache Software License', ], ) From 5675a2e8daa55274f35ae21bf1b32a3ee68ee9ad Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Thu, 22 Sep 2022 15:51:45 -0400 Subject: [PATCH 2/3] Fix 3.10 --- .github/workflows/ci.yml | 2 +- CONTRIBUTING.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e90c0cd59..d2129720b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ jobs: strategy: fail-fast: false matrix: - python: [3.7, 3.8, 3.9, 3.10, pypy3.7] + python: ['3.7', '3.8', '3.9', '3.10', 'pypy3.7'] steps: - uses: actions/checkout@v3 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 30685394e..1d500cba8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -85,7 +85,7 @@ information on using pull requests. ### Initial Setup -You need Python 3.6+ to build and test the code in this repo. +You need Python 3.7+ to build and test the code in this repo. We recommend using [pip](https://pypi.python.org/pypi/pip) for installing the necessary tools and project dependencies. Most recent versions of Python ship with pip. If your development environment From c322d81f793700bad6210dcd212abbec857fa6a9 Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Wed, 28 Sep 2022 15:47:22 -0400 Subject: [PATCH 3/3] update readme --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index 9c5101e3f..041c41673 100644 --- a/README.md +++ b/README.md @@ -43,8 +43,7 @@ requests, code review feedback, and also pull requests. ## Supported Python Versions -We currently support Python 3.6+. However, Python 3.6 support is deprecated, -and developers are strongly advised to use Python 3.7 or higher. Firebase +We currently support Python 3.7+. Firebase Admin Python SDK is also tested on PyPy and [Google App Engine](https://cloud.google.com/appengine/) environments.