Skip to content

Commit 2fa8a24

Browse files
committed
use updated checkOnlineAndOfflineResultsMatch test helper
1 parent ee841d8 commit 2fa8a24

File tree

1 file changed

+5
-11
lines changed
  • firebase-firestore/src/androidTest/java/com/google/firebase/firestore

1 file changed

+5
-11
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java

+5-11
Original file line numberDiff line numberDiff line change
@@ -1664,17 +1664,14 @@ public void testSDKUsesNotEqualFiltersSameAsServer() {
16641664
"j", map("code", 500L));
16651665
CollectionReference collection = testCollectionWithDocs(testDocs);
16661666

1667-
// populate cache with all documents first to ensure getDocsFromCache() scans all docs
1668-
waitFor(testCollectionWithDocs(testDocs).get());
1669-
16701667
Query query = collection.whereNotEqualTo("zip", 98101L);
1671-
checkOnlineAndOfflineResultsMatch(query, "a", "b", "d", "e", "f", "g", "h");
1668+
checkOnlineAndOfflineResultsMatch(collection, query, "a", "b", "d", "e", "f", "g", "h");
16721669

16731670
query = collection.whereNotEqualTo("zip", Double.NaN);
1674-
checkOnlineAndOfflineResultsMatch(query, "b", "c", "d", "e", "f", "g", "h");
1671+
checkOnlineAndOfflineResultsMatch(collection, query, "b", "c", "d", "e", "f", "g", "h");
16751672

16761673
query = collection.whereNotEqualTo("zip", null);
1677-
checkOnlineAndOfflineResultsMatch(query, "a", "b", "c", "d", "e", "f", "g", "h");
1674+
checkOnlineAndOfflineResultsMatch(collection, query, "a", "b", "c", "d", "e", "f", "g", "h");
16781675
}
16791676

16801677
@Test
@@ -1693,13 +1690,10 @@ public void testSDKUsesNotInFiltersSameAsServer() {
16931690
"j", map("code", 500L));
16941691
CollectionReference collection = testCollectionWithDocs(testDocs);
16951692

1696-
// populate cache with all documents first to ensure getDocsFromCache() scans all docs
1697-
waitFor(testCollectionWithDocs(testDocs).get());
1698-
16991693
Query query = collection.whereNotIn("zip", asList(98101L, 98103L, asList(98101L, 98102L)));
1700-
checkOnlineAndOfflineResultsMatch(query, "a", "b", "d", "e", "g", "h");
1694+
checkOnlineAndOfflineResultsMatch(collection, query, "a", "b", "d", "e", "g", "h");
17011695

17021696
query = collection.whereNotIn("zip", nullList());
1703-
checkOnlineAndOfflineResultsMatch(query);
1697+
checkOnlineAndOfflineResultsMatch(collection, query);
17041698
}
17051699
}

0 commit comments

Comments
 (0)