resolve comments

Author: milaGGL

firebase-firestore/CHANGELOG.md

@@ -1,4 +1,5 @@
 # Unreleased
+Fix Firestore failing to raise initial snapshot from empty local cache result.
 
 # 24.4.0
 * [unchanged] Updated to accommodate the release of the updated

firebase-firestore/src/main/java/com/google/firebase/firestore/core/SyncEngine.java

@@ -226,7 +226,6 @@ private ViewSnapshot initializeViewAndComputeSnapshot(
       Query mirrorQuery = this.queriesByTarget.get(targetId).get(0);
       currentTargetSyncState = this.queryViewsByQuery.get(mirrorQuery).getView().getSyncState();
     }
-    ;
     synthesizedCurrentChange =
         TargetChange.createSynthesizedTargetChangeForCurrentChange(
             currentTargetSyncState == SyncState.SYNCED, resumeToken);

firebase-firestore/src/main/java/com/google/firebase/firestore/core/View.java

@@ -300,8 +300,11 @@ public ViewChange applyChanges(DocumentChanges docChanges, TargetChange targetCh
     boolean syncStatedChanged = newSyncState != syncState;
     syncState = newSyncState;
     ViewSnapshot snapshot = null;
+
     if (viewChanges.size() != 0 || syncStatedChanged) {
       boolean fromCache = newSyncState == SyncState.LOCAL;
+      boolean hasCachedResults =
+          targetChange == null ? false : !targetChange.getResumeToken().isEmpty();
       snapshot =
           new ViewSnapshot(
               query,
@@ -312,9 +315,7 @@ public ViewChange applyChanges(DocumentChanges docChanges, TargetChange targetCh
               docChanges.mutatedKeys,
               syncStatedChanged,
               /* excludesMetadataChanges= */ false,
-              /* hasCachedResults= */ targetChange == null
-                  ? false
-                  : !targetChange.getResumeToken().isEmpty());
+              hasCachedResults);
     }
     return new ViewChange(snapshot, limboDocumentChanges);
   }