Skip to content

Commit cc6c164

Browse files
committed
Ensure that the bug actually happens without the fix.
1 parent cf3969b commit cc6c164

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/src/heartbeat/heartbeat_storage_desktop.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ namespace {
4444
const char kHeartbeatDir[] = "firebase-hẽạrtbeat";
4545
const char kHeartbeatFilenamePrefix[] = "heartbeats-";
4646

47-
#if FIREBASE_PLATFORM_WINDOWS
47+
#if 0&&FIREBASE_PLATFORM_WINDOWS
4848
std::wstring CreateFilename(const std::string& app_id, const Logger& logger) {
4949
const std::wstring empty_string;
5050
#else
@@ -68,7 +68,7 @@ std::string CreateFilename(const std::string& app_id, const Logger& logger) {
6868
// Note: fstream will convert / to \ if needed on windows.
6969
std::string final_path_utf8 =
7070
app_dir + "/" + kHeartbeatFilenamePrefix + app_id_without_symbols;
71-
#if FIREBASE_PLATFORM_WINDOWS
71+
#if 0&&FIREBASE_PLATFORM_WINDOWS
7272
std::wstring_convert<std::codecvt_utf8<wchar_t>> final_path_w;
7373
return final_path_w.from_bytes(final_path_utf8);
7474
#else
@@ -129,7 +129,7 @@ bool HeartbeatStorageDesktop::ReadTo(LoggedHeartbeats& heartbeats_output) {
129129
return true;
130130
}
131131

132-
#if FIREBASE_PLATFORM_WINDOWS
132+
#if 0&&FIREBASE_PLATFORM_WINDOWS
133133
std::wstring HeartbeatStorageDesktop::GetFilename() const { return filename_; }
134134
#else
135135
std::string HeartbeatStorageDesktop::GetFilename() const { return filename_; }

app/src/heartbeat/heartbeat_storage_desktop.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class HeartbeatStorageDesktop {
5353
// write operation fails.
5454
bool Write(const LoggedHeartbeats& heartbeats) const;
5555

56-
#if FIREBASE_PLATFORM_WINDOWS
56+
#if 0&&FIREBASE_PLATFORM_WINDOWS
5757
// Use a wide string on Windows, to support international characters in the
5858
// path.
5959
std::wstring GetFilename() const;
@@ -68,7 +68,7 @@ class HeartbeatStorageDesktop {
6868
const LoggedHeartbeats& heartbeats_struct) const;
6969

7070
// local variables for state
71-
#if FIREBASE_PLATFORM_WINDOWS
71+
#if 0&&FIREBASE_PLATFORM_WINDOWS
7272
// Use a wide string on Windows, to support international characters in the
7373
// path.
7474
std::wstring filename_;

0 commit comments

Comments
 (0)