File tree Expand file tree Collapse file tree 2 files changed +9
-2
lines changed Expand file tree Collapse file tree 2 files changed +9
-2
lines changed Original file line number Diff line number Diff line change
1
+ # Unreleased
2
+ - [ fixed] Fixed compiler warnings in ` local_serializer.cc ` about "implicit
3
+ conversion loses integer precision" that were introduced in 8.13.0 (#9430 ).
4
+
1
5
# v8.12.1
2
6
- [ changed] Add more details to the assertion failure in OrderBy::Compare() to
3
7
help with future debugging (#9258 ).
Original file line number Diff line number Diff line change @@ -499,9 +499,12 @@ LocalSerializer::EncodeFieldIndexSegments(
499
499
result->query_scope =
500
500
google_firestore_admin_v1_Index_QueryScope_COLLECTION_GROUP;
501
501
502
- result->fields_count = segments.size ();
502
+ // Explicitly cast the result of segments.size() to suppress compiler warnings
503
+ // about implicit conversion resulting in potential loss of precision.
504
+ const auto segments_size = static_cast <pb_size_t >(segments.size ());
505
+ result->fields_count = segments_size;
503
506
result->fields =
504
- MakeArray<google_firestore_admin_v1_Index_IndexField>(segments. size () );
507
+ MakeArray<google_firestore_admin_v1_Index_IndexField>(segments_size );
505
508
int i = 0 ;
506
509
for (const auto & segment : segments) {
507
510
google_firestore_admin_v1_Index_IndexField field;
You can’t perform that action at this time.
0 commit comments