Skip to content

Commit 2429ac1

Browse files
authored
[Auth] Add aria-hidden='true' attribute to embedded iframe (#5633)
* Add aria-hidden='true' attribute to embedded iframe * Add changeset
1 parent 7092f5f commit 2429ac1

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

.changeset/olive-coats-deliver.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@firebase/auth": patch
3+
---
4+
5+
Add the attribute `aria-hidden="true"` to the embedded iframe

packages/auth/src/platform_browser/iframe/iframe.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ describe('platform_browser/iframe/iframe', () => {
8484
top: '-100px',
8585
width: '1px',
8686
height: '1px'
87-
}
87+
},
88+
'aria-hidden': 'true',
8889
});
8990
expect(iframeSettings.dontclear).to.be.true;
9091
});

packages/auth/src/platform_browser/iframe/iframe.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ const IFRAME_ATTRIBUTES = {
3737
top: '-100px',
3838
width: '1px',
3939
height: '1px'
40-
}
40+
},
41+
'aria-hidden': 'true'
4142
};
4243

4344
// Map from apiHost to endpoint ID for passing into iframe. In current SDK, apiHost can be set to

0 commit comments

Comments
 (0)