Skip to content

Commit 3b26db4

Browse files
Remove all namespace imports (#3660)
1 parent 05f8002 commit 3b26db4

26 files changed

+523
-408
lines changed

packages/firestore/rollup.config.browser.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,27 @@ export default [
2828
sourcemap: true
2929
},
3030
plugins: util.es2017Plugins('browser', /* mangled= */ true),
31-
external: util.resolveBrowserExterns
31+
external: util.resolveBrowserExterns,
32+
treeshake: {
33+
moduleSideEffects: false
34+
}
3235
},
3336
{
3437
input: pkg.esm2017,
3538
output: { file: pkg.module, format: 'es', sourcemap: true },
3639
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
37-
external: util.resolveBrowserExterns
40+
external: util.resolveBrowserExterns,
41+
treeshake: {
42+
moduleSideEffects: false
43+
}
3844
},
3945
{
4046
input: pkg.esm2017,
4147
output: { file: pkg.browser, format: 'cjs', sourcemap: true },
4248
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
43-
external: util.resolveBrowserExterns
49+
external: util.resolveBrowserExterns,
50+
treeshake: {
51+
moduleSideEffects: false
52+
}
4453
}
4554
];

packages/firestore/rollup.config.browser.memory.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ export default [
2929
sourcemap: true
3030
},
3131
plugins: util.es2017Plugins('browser', /* mangled= */ true),
32-
external: util.resolveBrowserExterns
32+
external: util.resolveBrowserExterns,
33+
treeshake: {
34+
moduleSideEffects: false
35+
}
3336
},
3437
{
3538
input: path.resolve('./memory', memoryPkg['esm2017']),
@@ -39,7 +42,10 @@ export default [
3942
sourcemap: true
4043
},
4144
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
42-
external: util.resolveBrowserExterns
45+
external: util.resolveBrowserExterns,
46+
treeshake: {
47+
moduleSideEffects: false
48+
}
4349
},
4450
{
4551
input: path.resolve('./memory', memoryPkg['esm2017']),
@@ -49,6 +55,9 @@ export default [
4955
sourcemap: true
5056
},
5157
plugins: util.es2017ToEs5Plugins(/* mangled= */ true),
52-
external: util.resolveBrowserExterns
58+
external: util.resolveBrowserExterns,
59+
treeshake: {
60+
moduleSideEffects: false
61+
}
5362
}
5463
];

packages/firestore/rollup.config.node.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,18 @@ export default [
3939
'process.env.FIRESTORE_PROTO_ROOT': JSON.stringify('src/protos')
4040
})
4141
],
42-
external: util.resolveNodeExterns
42+
external: util.resolveNodeExterns,
43+
treeshake: {
44+
moduleSideEffects: false
45+
}
4346
},
4447
{
4548
input: pkg['main-esm2017'],
4649
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
4750
plugins: util.es2017ToEs5Plugins(),
48-
external: util.resolveNodeExterns
51+
external: util.resolveNodeExterns,
52+
treeshake: {
53+
moduleSideEffects: false
54+
}
4955
}
5056
];

packages/firestore/rollup.config.node.memory.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import * as path from 'path';
1919
import replace from 'rollup-plugin-replace';
20-
import copy from 'rollup-plugin-copy-assets';
2120
import memoryPkg from './memory/package.json';
2221

2322
const util = require('./rollup.shared');
@@ -32,15 +31,14 @@ export default [
3231
},
3332
plugins: [
3433
...util.es2017Plugins('node'),
35-
// Needed as we also use the *.proto files
36-
copy({
37-
assets: ['./src/protos']
38-
}),
3934
replace({
4035
'process.env.FIRESTORE_PROTO_ROOT': JSON.stringify('src/protos')
4136
})
4237
],
43-
external: util.resolveNodeExterns
38+
external: util.resolveNodeExterns,
39+
treeshake: {
40+
moduleSideEffects: false
41+
}
4442
},
4543
{
4644
input: path.resolve('./memory', memoryPkg['main-esm2017']),
@@ -50,6 +48,9 @@ export default [
5048
sourcemap: true
5149
},
5250
plugins: util.es2017ToEs5Plugins(),
53-
external: util.resolveNodeExterns
51+
external: util.resolveNodeExterns,
52+
treeshake: {
53+
moduleSideEffects: false
54+
}
5455
}
5556
];

packages/firestore/rollup.config.rn.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,8 @@ export default {
2727
sourcemap: true
2828
},
2929
plugins: util.es2017Plugins('rn', /* mangled= */ true),
30-
external: util.resolveBrowserExterns
30+
external: util.resolveBrowserExterns,
31+
treeshake: {
32+
moduleSideEffects: false
33+
}
3134
};

packages/firestore/rollup.config.rn.memory.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,8 @@ export default {
2828
sourcemap: true
2929
},
3030
plugins: util.es2017Plugins('rn', /* mangled= */ true),
31-
external: util.resolveBrowserExterns
31+
external: util.resolveBrowserExterns,
32+
treeshake: {
33+
moduleSideEffects: false
34+
}
3235
};

0 commit comments

Comments
 (0)