Update names.

Author: ehsannas

packages/firestore/src/local/indexeddb_document_overlay_cache.ts

@@ -20,7 +20,7 @@ import {
   DocumentKeySet,
   MutationMap,
   OverlayMap,
-  newDocumentKeyToOverlayMap
+  newOverlayMap
 } from '../model/collections';
 import { DocumentKey } from '../model/document_key';
 import { Overlay } from '../model/overlay';
@@ -123,7 +123,7 @@ export class IndexedDbDocumentOverlayCache implements DocumentOverlayCache {
     collection: ResourcePath,
     sinceBatchId: number
   ): PersistencePromise<OverlayMap> {
-    const result = newDocumentKeyToOverlayMap();
+    const result = newOverlayMap();
     const collectionPath = encodeResourcePath(collection);
     // We want batch IDs larger than `sinceBatchId`, and so the lower bound
     // is not inclusive.
@@ -149,7 +149,7 @@ export class IndexedDbDocumentOverlayCache implements DocumentOverlayCache {
     sinceBatchId: number,
     count: number
   ): PersistencePromise<OverlayMap> {
-    const result = newDocumentKeyToOverlayMap();
+    const result = newOverlayMap();
     let currentBatchId: number | undefined = undefined;
     // We want batch IDs larger than `sinceBatchId`, and so the lower bound
     // is not inclusive.

packages/firestore/src/local/memory_document_overlay_cache.ts

@@ -20,7 +20,7 @@ import {
   DocumentKeySet,
   MutationMap,
   OverlayMap,
-  newDocumentKeyToOverlayMap
+  newOverlayMap
 } from '../model/collections';
 import { DocumentKey } from '../model/document_key';
 import { Mutation } from '../model/mutation';
@@ -79,7 +79,7 @@ export class MemoryDocumentOverlayCache implements DocumentOverlayCache {
     collection: ResourcePath,
     sinceBatchId: number
   ): PersistencePromise<OverlayMap> {
-    const result = newDocumentKeyToOverlayMap();
+    const result = newOverlayMap();
 
     const immediateChildrenPathLength = collection.length + 1;
     const prefix = new DocumentKey(collection.child(''));
@@ -124,7 +124,7 @@ export class MemoryDocumentOverlayCache implements DocumentOverlayCache {
       if (overlay.largestBatchId > sinceBatchId) {
         let overlaysForBatchId = batchIdToOverlays.get(overlay.largestBatchId);
         if (overlaysForBatchId === null) {
-          overlaysForBatchId = newDocumentKeyToOverlayMap();
+          overlaysForBatchId = newOverlayMap();
           batchIdToOverlays = batchIdToOverlays.insert(
             overlay.largestBatchId,
             overlaysForBatchId
@@ -134,7 +134,7 @@ export class MemoryDocumentOverlayCache implements DocumentOverlayCache {
       }
     }
 
-    const result = newDocumentKeyToOverlayMap();
+    const result = newOverlayMap();
     const batchIter = batchIdToOverlays.getIterator();
     while (batchIter.hasNext()) {
       const entry = batchIter.getNext();

packages/firestore/src/model/collections.ts

@@ -51,15 +51,15 @@ export function documentMap(): DocumentMap {
 }
 
 export type OverlayMap = ObjectMap<DocumentKey, Overlay>;
-export function newDocumentKeyToOverlayMap(): OverlayMap {
+export function newOverlayMap(): OverlayMap {
   return new ObjectMap<DocumentKey, Overlay>(
     key => key.toString(),
     (l, r) => l.isEqual(r)
   );
 }
 
 export type MutationMap = ObjectMap<DocumentKey, Mutation>;
-export function newDocumentKeyToMutationMap(): MutationMap {
+export function newMutationMap(): MutationMap {
   return new ObjectMap<DocumentKey, Mutation>(
     key => key.toString(),
     (l, r) => l.isEqual(r)

packages/firestore/test/unit/local/document_overlay_cache.test.ts

@@ -23,7 +23,7 @@ import {
   documentKeySet,
   MutationMap,
   OverlayMap,
-  newDocumentKeyToMutationMap
+  newMutationMap
 } from '../../../src/model/collections';
 import { Mutation, mutationEquals } from '../../../src/model/mutation';
 import { addEqualityMatcher } from '../../util/equality_matcher';
@@ -89,7 +89,7 @@ function genericDocumentOverlayCacheTests(): void {
     largestBatch: number,
     ...mutations: Mutation[]
   ): Promise<void> {
-    const data: MutationMap = newDocumentKeyToMutationMap();
+    const data: MutationMap = newMutationMap();
     for (const mutation of mutations) {
       data.set(mutation.key, mutation);
     }
@@ -100,7 +100,7 @@ function genericDocumentOverlayCacheTests(): void {
     largestBatch: number,
     ...overlayKeys: string[]
   ): Promise<void> {
-    const data: MutationMap = newDocumentKeyToMutationMap();
+    const data: MutationMap = newMutationMap();
     for (const overlayKey of overlayKeys) {
       data.set(key(overlayKey), setMutation(overlayKey, {}));
     }