Add retry code test

Author: hsubox76

packages/app-check/src/api.ts

@@ -126,7 +126,6 @@ function _activate(
   newState.cachedTokenPromise = readTokenFromStorage(app).then(cachedToken => {
     if (cachedToken && isValid(cachedToken)) {
       setState(app, { ...getState(app), token: cachedToken });
-      console.log('notifying token listeners');
       // notify all listeners with the cached token
       notifyTokenListeners(app, { token: cachedToken.token });
     }

packages/app-check/src/internal-api.test.ts

@@ -38,12 +38,14 @@ import * as reCAPTCHA from './recaptcha';
 import * as client from './client';
 import * as storage from './storage';
 import * as util from './util';
+import { logger } from './logger';
 import { getState, clearState, setState, getDebugState } from './state';
 import { AppCheckTokenListener } from './public-types';
 import { Deferred, FirebaseError } from '@firebase/util';
 import { ReCaptchaV3Provider } from './providers';
 import { AppCheckService } from './factory';
 import { ListenerType } from './types';
+import { AppCheckError } from './errors';
 
 const fakeRecaptchaToken = 'fake-recaptcha-token';
 const fakeRecaptchaAppCheckToken = {
@@ -362,24 +364,47 @@ describe('internal api', () => {
       );
       expect(token).to.deep.equal({ token: fakeRecaptchaAppCheckToken.token });
     });
-    it('throttle', async () => {
+    it('throttles exponentially on 503', async () => {
       const appCheck = initializeAppCheck(app, {
         provider: new ReCaptchaV3Provider(FAKE_SITE_KEY)
       });
-      stub(
-        client,
-        'exchangeToken'
-      ).returns(
+      const warnStub = stub(logger, 'warn');
+      stub(client, 'exchangeToken').returns(
         Promise.reject(
-          new FirebaseError('test-error', 'test error msg', { httpStatus: 503 })
+          new FirebaseError(
+            AppCheckError.FETCH_STATUS_ERROR,
+            'test error msg',
+            { httpStatus: 503 }
+          )
         )
       );
 
       const token = await getToken(appCheck as AppCheckService);
 
-      expect(token.error?.message).to.equal(
-        'sdfa'
+      expect(token.error?.message).to.include('503');
+      expect(token.error?.message).to.include('00m');
+      expect(warnStub.args[0][0]).to.include('503');
+    });
+    it('throttles 1d on 403', async () => {
+      const appCheck = initializeAppCheck(app, {
+        provider: new ReCaptchaV3Provider(FAKE_SITE_KEY)
+      });
+      const warnStub = stub(logger, 'warn');
+      stub(client, 'exchangeToken').returns(
+        Promise.reject(
+          new FirebaseError(
+            AppCheckError.FETCH_STATUS_ERROR,
+            'test error msg',
+            { httpStatus: 403 }
+          )
+        )
       );
+
+      const token = await getToken(appCheck as AppCheckService);
+
+      expect(token.error?.message).to.include('403');
+      expect(token.error?.message).to.include('1d');
+      expect(warnStub.args[0][0]).to.include('403');
     });
   });
 

packages/app-check/src/internal-api.ts

@@ -139,7 +139,7 @@ export async function getToken(
     }
     token = await state.exchangeTokenPromise;
   } catch (e) {
-    if ((e as FirebaseError).code === AppCheckError.THROTTLED) {
+    if ((e as FirebaseError).code === `appCheck/${AppCheckError.THROTTLED}`) {
       // Warn if throttled, but do not treat it as an error.
       logger.warn((e as FirebaseError).message);
     } else {