Fix assert fails (#4667) (#4713)

Author: MattGoldwater

.changeset/happy-planets-lick.md

@@ -0,0 +1,5 @@
+---
+"@firebase/rules-unit-testing": patch
+---
+
+Fix assertFails not correctly catching RTDB permission denied errors (#4667).

packages/rules-unit-testing/src/api/index.ts

@@ -583,7 +583,8 @@ export function assertFails(pr: Promise<any>): any {
       const isPermissionDenied =
         errCode === 'permission-denied' ||
         errCode === 'permission_denied' ||
-        errMessage.indexOf('permission_denied') >= 0;
+        errMessage.indexOf('permission_denied') >= 0 || 
+        errMessage.indexOf('permission denied') >= 0;
 
       if (!isPermissionDenied) {
         return Promise.reject(

packages/rules-unit-testing/test/database.test.ts

@@ -128,6 +128,31 @@ describe('Testing Module Tests', function () {
       .catch(() => {});
   });
 
+  it('assertFails() if message is Permission denied', async function () {
+    const success = Promise.resolve('success');
+    const permissionDenied = Promise.reject({
+      message: 'Permission denied'
+    });
+    const otherFailure = Promise.reject('failure');
+    await firebase
+      .assertFails(success)
+      .then(() => {
+        throw new Error('Expected success to fail.');
+      })
+      .catch(() => {});
+
+    await firebase.assertFails(permissionDenied).catch(() => {
+      throw new Error('Expected permissionDenied to succeed.');
+    });
+
+    await firebase
+      .assertFails(otherFailure)
+      .then(() => {
+        throw new Error('Expected otherFailure to fail.');
+      })
+      .catch(() => {});
+  });
+
   it('discoverEmulators() finds all running emulators', async () => {
     const options = await firebase.discoverEmulators();