Skip to content

Commit 71ab1f5

Browse files
maneeshthsubox76
authored andcommitted
Fix Data Connect Types (#8898)
1 parent 44b22e3 commit 71ab1f5

File tree

4 files changed

+23
-2
lines changed

4 files changed

+23
-2
lines changed

.changeset/hungry-snails-drive.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@firebase/data-connect": patch
3+
---
4+
5+
Fix DataConnectOperationError.

common/api-review/data-connect.api.md

+17-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,20 @@ export const CallerSdkTypeEnum: {
2424
readonly GeneratedAngular: "GeneratedAngular";
2525
};
2626

27+
// @public (undocumented)
28+
export type Code = DataConnectErrorCode;
29+
30+
// @public (undocumented)
31+
export const Code: {
32+
OTHER: DataConnectErrorCode;
33+
ALREADY_INITIALIZED: DataConnectErrorCode;
34+
NOT_INITIALIZED: DataConnectErrorCode;
35+
NOT_SUPPORTED: DataConnectErrorCode;
36+
INVALID_ARGUMENT: DataConnectErrorCode;
37+
PARTIAL_ERROR: DataConnectErrorCode;
38+
UNAUTHORIZED: DataConnectErrorCode;
39+
};
40+
2741
// @public
2842
export function connectDataConnectEmulator(dc: DataConnect, host: string, port?: number, sslEnabled?: boolean): void;
2943

@@ -54,7 +68,9 @@ export class DataConnect {
5468

5569
// @public
5670
export class DataConnectError extends FirebaseError {
57-
}
71+
/* Excluded from this release type: name */
72+
constructor(code: Code, message: string);
73+
}
5874

5975
// @public (undocumented)
6076
export type DataConnectErrorCode = 'other' | 'already-initialized' | 'not-initialized' | 'not-supported' | 'invalid-argument' | 'partial-error' | 'unauthorized';

packages/data-connect/src/api/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export { setLogLevel } from '../logger';
2424
export { validateArgs } from '../util/validateArgs';
2525
export {
2626
DataConnectErrorCode,
27+
Code,
2728
DataConnectError,
2829
DataConnectOperationError,
2930
DataConnectOperationFailureResponse,

packages/data-connect/src/core/error.ts

-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ export class DataConnectError extends FirebaseError {
4343
/** @internal */
4444
readonly name: string = 'DataConnectError';
4545

46-
/** @hideconstructor */
4746
constructor(code: Code, message: string) {
4847
super(code, message);
4948

0 commit comments

Comments
 (0)