Support getAuth() after getDatabase() (#4889)

Author: schmidt-sebastian

packages/database/src/core/AppCheckTokenProvider.ts

@@ -42,7 +42,19 @@ export class AppCheckTokenProvider {
 
   getToken(forceRefresh?: boolean): Promise<AppCheckTokenResult> {
     if (!this.appCheck) {
-      return Promise.resolve(null);
+      return new Promise<AppCheckTokenResult>((resolve, reject) => {
+        // Support delayed initialization of FirebaseAppCheck. This allows our
+        // customers to initialize the RTDB SDK before initializing Firebase
+        // AppCheck and ensures that all requests are authenticated if a token
+        // becomes available before the timoeout below expires.
+        setTimeout(() => {
+          if (this.appCheck) {
+            this.getToken(forceRefresh).then(resolve, reject);
+          } else {
+            resolve(null);
+          }
+        }, 0);
+      });
     }
     return this.appCheck.getToken(forceRefresh);
   }

packages/database/src/core/AuthTokenProvider.ts

@@ -36,20 +36,33 @@ export interface AuthTokenProvider {
  */
 export class FirebaseAuthTokenProvider implements AuthTokenProvider {
   private auth_: FirebaseAuthInternal | null = null;
+
   constructor(
     private appName_: string,
     private firebaseOptions_: object,
     private authProvider_: Provider<FirebaseAuthInternalName>
   ) {
     this.auth_ = authProvider_.getImmediate({ optional: true });
     if (!this.auth_) {
-      authProvider_.get().then(auth => (this.auth_ = auth));
+      authProvider_.onInit(auth => (this.auth_ = auth));
     }
   }
 
   getToken(forceRefresh: boolean): Promise<FirebaseAuthTokenData> {
     if (!this.auth_) {
-      return Promise.resolve(null);
+      return new Promise<FirebaseAuthTokenData>((resolve, reject) => {
+        // Support delayed initialization of FirebaseAuth. This allows our
+        // customers to initialize the RTDB SDK before initializing Firebase
+        // Auth and ensures that all requests are authenticated if a token
+        // becomes available before the timoeout below expires.
+        setTimeout(() => {
+          if (this.auth_) {
+            this.getToken(forceRefresh).then(resolve, reject);
+          } else {
+            resolve(null);
+          }
+        }, 0);
+      });
     }
 
     return this.auth_.getToken(forceRefresh).catch(error => {
@@ -70,7 +83,6 @@ export class FirebaseAuthTokenProvider implements AuthTokenProvider {
     if (this.auth_) {
       this.auth_.addAuthTokenListener(listener);
     } else {
-      setTimeout(() => listener(null), 0);
       this.authProvider_
         .get()
         .then(auth => auth.addAuthTokenListener(listener));

packages/database/src/core/PersistentConnection.ts

@@ -244,6 +244,7 @@ export class PersistentConnection extends ServerActions {
 
     return deferred.promise;
   }
+
   listen(
     query: QueryContext,
     currentHashFn: () => string,
@@ -351,6 +352,7 @@ export class PersistentConnection extends ServerActions {
       }
     }
   }
+
   refreshAuthToken(token: string) {
     this.authToken_ = token;
     this.log_('Auth token refreshed');
@@ -488,6 +490,7 @@ export class PersistentConnection extends ServerActions {
 
     this.sendRequest(action, req);
   }
+
   onDisconnectPut(
     pathString: string,
     data: unknown,
@@ -506,6 +509,7 @@ export class PersistentConnection extends ServerActions {
       });
     }
   }
+
   onDisconnectMerge(
     pathString: string,
     data: unknown,
@@ -524,6 +528,7 @@ export class PersistentConnection extends ServerActions {
       });
     }
   }
+
   onDisconnectCancel(
     pathString: string,
     onComplete?: (a: string, b: string) => void
@@ -561,6 +566,7 @@ export class PersistentConnection extends ServerActions {
       }
     });
   }
+
   put(
     pathString: string,
     data: unknown,
@@ -569,6 +575,7 @@ export class PersistentConnection extends ServerActions {
   ) {
     this.putInternal('p', pathString, data, onComplete, hash);
   }
+
   merge(
     pathString: string,
     data: unknown,
@@ -638,6 +645,7 @@ export class PersistentConnection extends ServerActions {
       }
     });
   }
+
   reportStats(stats: { [k: string]: unknown }) {
     // If we're not connected, we just drop the stats.
     if (this.connected_) {