Add getBytes

Author: schmidt-sebastian

common/api-review/storage.api.md

@@ -65,6 +65,9 @@ export interface FullMetadata extends UploadMetadata {
     updated: string;
 }
 
+// @public
+export function getBytes(ref: StorageReference): Promise<ArrayBuffer>;
+
 // @internal (undocumented)
 export function _getChild(ref: StorageReference, childPath: string): _Reference;
 

packages/storage/exp/api.ts

@@ -47,7 +47,8 @@ import {
   getDownloadURL as getDownloadURLInternal,
   deleteObject as deleteObjectInternal,
   Reference,
-  _getChild as _getChildInternal
+  _getChild as _getChildInternal,
+  getBytesInternal
 } from '../src/reference';
 import { STORAGE_TYPE } from './constants';
 import { EmulatorMockTokenOptions, getModularInstance } from '@firebase/util';
@@ -62,6 +63,23 @@ export { UploadTask as _UploadTask } from '../src/task';
 export type { Reference as _Reference } from '../src/reference';
 export { FbsBlob as _FbsBlob } from '../src/implementation/blob';
 
+/**
+ * Downloads the data at the object's location. Returns an error if the object
+ * is not found.
+ *
+ * To use this functionality, you have to whitelist your app's origin in you
+ * Cloud Storage bucket. See also
+ * https://cloud.google.com/storage/docs/configuring-cors
+ *
+ * @public
+ * @param ref - StorageReference where data should be download.
+ * @returns A Promise containing the object's bytes
+ */
+export function getBytes(ref: StorageReference): Promise<ArrayBuffer> {
+  ref = getModularInstance(ref);
+  return getBytesInternal(ref as Reference);
+}
+
 /**
  * Uploads data to this object's location.
  * The upload is not resumable.

packages/storage/exp/index.ts

@@ -27,7 +27,6 @@ import {
   SDK_VERSION
 } from '@firebase/app-exp';
 
-import { ConnectionPool } from '../src/implementation/connectionPool';
 import { FirebaseStorageImpl } from '../src/service';
 import {
   Component,
@@ -56,7 +55,6 @@ function factory(
     app,
     authProvider,
     appCheckProvider,
-    new ConnectionPool(),
     url,
     SDK_VERSION
   );

packages/storage/index.ts

@@ -20,7 +20,6 @@ import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { StringFormat } from './src/implementation/string';
 import { TaskEvent, TaskState } from './src/implementation/taskenums';
 
-import { ConnectionPool } from './src/implementation/connectionPool';
 import { ReferenceCompat } from './compat/reference';
 import { StorageServiceCompat } from './compat/service';
 import { FirebaseStorageImpl } from './src/service';
@@ -59,7 +58,6 @@ function factory(
       app,
       authProvider,
       appCheckProvider,
-      new ConnectionPool(),
       url,
       firebase.SDK_VERSION
     )

packages/storage/src/implementation/connection.ts

@@ -15,18 +15,18 @@
  * limitations under the License.
  */
 
-/**
- * Network headers
- */
-export interface Headers {
-  [name: string]: string;
-}
+/** Network headers */
+export type Headers = Record<string, string>;
 
 /**
  * A lightweight wrapper around XMLHttpRequest with a
  * goog.net.XhrIo-like interface.
+ *
+ * ResponseType is generally either `string` or `ArrayBuffer`. You can create
+ * a new connection by invoking `newTextConnection()` or
+ * `newBytesConnection()`.
  */
-export interface Connection {
+export interface Connection<ResponseType> {
   send(
     url: string,
     method: string,
@@ -38,6 +38,8 @@ export interface Connection {
 
   getStatus(): number;
 
+  getResponse(): ResponseType;
+
   getResponseText(): string;
 
   /**