Skip to content

Commit cd96b4c

Browse files
committed
remove exp references
1 parent 79035c0 commit cd96b4c

File tree

10 files changed

+26
-138
lines changed

10 files changed

+26
-138
lines changed

.github/CODEOWNERS

+20-21
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535

3636
# Database Code
3737
packages/database @schmidt-sebastian @jsdt @firebase/jssdk-global-approvers
38+
packages/database-compat @schmidt-sebastian @jsdt @firebase/jssdk-global-approvers
3839
packages/database-types @schmidt-sebastian @jsdt @firebase/jssdk-global-approvers
3940

4041
# Firestore Code
@@ -45,56 +46,54 @@ integration/firestore @firebase/firestore-js-team @firebase/jssdk-global-approv
4546

4647
# Storage Code
4748
packages/storage @schmidt-sebastian @firebase/jssdk-global-approvers
49+
packages/storage-compat @schmidt-sebastian @firebase/jssdk-global-approvers
4850
packages/storage-types @schmidt-sebastian @firebase/jssdk-global-approvers
4951

5052
# Messaging Code
5153
packages/messaging @zwu52 @chliangGoogle @ciarand @firebase/jssdk-global-approvers
54+
packages/messaging-compat @zwu52 @chliangGoogle @ciarand @firebase/jssdk-global-approvers
5255
packages/messaging-types @zwu52 @chliangGoogle @ciarand @firebase/jssdk-global-approvers
56+
packages/messaging-interop-types @zwu52 @chliangGoogle @ciarand @firebase/jssdk-global-approvers
5357
integration/messaging @zwu52 @chliangGoogle @ciarand @firebase/jssdk-global-approvers
5458

5559
# Auth Code
5660
packages/auth @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
61+
packages/auth-compat @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
5762
packages/auth-types @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
63+
packages/auth-interop-types @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
5864

5965
# Testing Code
60-
packages/testing @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
6166
packages/rules-unit-testing @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
6267

6368
# Installations
64-
packages/installations @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers
65-
packages/installations-types @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers
69+
packages/installations @avolkovi @yoyomyo @firebase/jssdk-global-approvers
70+
packages/installations-compat @avolkovi @yoyomyo @firebase/jssdk-global-approvers
71+
packages/installations-types @avolkovi @yoyomyo @firebase/jssdk-global-approvers
6672

6773
# Performance Code
68-
packages/performance @alikn @zijianjoy @firebase/jssdk-global-approvers
69-
packages/performance-types @alikn @zijianjoy @firebase/jssdk-global-approvers
74+
packages/performance @jposuna @firebase/jssdk-global-approvers
75+
packages/performance-compat @jposuna @firebase/jssdk-global-approvers
76+
packages/performance-types @jposuna @firebase/jssdk-global-approvers
7077

7178
# Analytics Code
7279
packages/analytics @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
80+
packages/analytics-compat @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
7381
packages/analytics-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
7482

7583
# Remote Config Code
7684
packages/remote-config @erikeldridge @firebase/jssdk-global-approvers
85+
packages/remote-config-compat @erikeldridge @firebase/jssdk-global-approvers
7786
packages/remote-config-types @erikeldridge @firebase/jssdk-global-approvers
7887

88+
# App Check Code
89+
packages/app-check @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
90+
packages/app-check-compat @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
91+
packages/app-check-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
92+
packages/app-check-interop-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
93+
7994
# Documentation Changes
8095
packages/firebase/index.d.ts @egilmorez @firebase/jssdk-global-approvers
8196
scripts/docgen/content-sources/ @egilmorez @firebase/jssdk-global-approvers
8297

8398
# Changeset
8499
.changeset @egilmorez @firebase/jssdk-changeset-approvers @firebase/firestore-js-team @firebase/jssdk-global-approvers
85-
86-
# Auth-Exp Code
87-
packages-exp/auth-exp @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
88-
packages-exp/auth-compat-exp @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
89-
90-
# Installations-Exp Code
91-
packages/installations-exp @avolkovi @yoyomyo @firebase/jssdk-global-approvers
92-
packages/installations-types-exp @avolkovi @yoyomyo @firebase/jssdk-global-approvers
93-
94-
# Perf-Exp Code
95-
packages/performance-exp @alikn @zijianjoy @firebase/jssdk-global-approvers
96-
packages/performance-types-exp @alikn @zijianjoy @firebase/jssdk-global-approvers
97-
98-
# RC-Exp Code
99-
packages/remote-config-exp @erikeldridge @firebase/jssdk-global-approvers
100-
packages/remote-config-compat @erikeldridge @firebase/jssdk-global-approvers

.gitignore

-2
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,8 @@ package-lock.json
8484

8585
# temp folder used by api-extractor
8686
temp
87-
packages-exp/**/temp
8887

8988
# temp markdowns generated for individual SDKs
90-
packages-exp/**/docs
9189
packages/**/docs
9290

9391
# files generated by api-extractor that should not be tracked

lerna.json

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"npmClient": "yarn",
44
"packages": [
55
"packages/*",
6-
"packages-exp/*",
76
"integration/*",
87
"repo-scripts/*"
98
],

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"lint:fix": "lerna run --scope @firebase/* lint:fix",
4747
"size-report": "ts-node-script scripts/size_report/report_binary_size.ts",
4848
"modular-export-size-report": "ts-node-script scripts/size_report/report_modular_export_binary_size.ts",
49-
"api-report": "lerna run --scope @firebase/*-exp --scope @firebase/firestore --scope @firebase/storage --scope @firebase/storage-types --scope @firebase/database api-report",
49+
"api-report": "lerna run --scope @firebase/* api-report",
5050
"docgen:exp": "ts-node-script scripts/exp/docgen.ts",
5151
"postinstall": "yarn --cwd repo-scripts/changelog-generator build",
5252
"sa": "ts-node-script repo-scripts/size-analysis/cli.ts",
@@ -58,7 +58,6 @@
5858
},
5959
"workspaces": [
6060
"packages/*",
61-
"packages-exp/*",
6261
"integration/*",
6362
"repo-scripts/*"
6463
],

packages/analytics/rollup.config.release.js

-73
This file was deleted.

packages/app/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"test:browser": "karma start --single-run",
2323
"test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha src/**/*.test.ts --config ../../config/mocharc.node.js",
2424
"api-report": "api-extractor run --local --verbose",
25-
"predoc": "node ../../scripts/exp/remove-exp.js temp",
2625
"doc": "api-documenter markdown --input temp --output docs",
2726
"build:doc": "yarn build && yarn doc",
2827
"typings:public": "node ../../scripts/exp/use_typings.js ./dist/app-public.d.ts",

repo-scripts/size-analysis/package-analysis.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,8 @@ export async function analyzePackageSize(
6969
writeReportToFile(jsonReport, resolve(argv.output));
7070
} else if (!argv.inputDtsFile && !argv.inputBundleFile) {
7171
// retrieve All Module Names
72-
// TODO: update the workspace once exp packages are officially released
7372
let allModulesLocation = await mapWorkspaceToPackages([
74-
`${projectRoot}/packages-exp/*`
73+
`${projectRoot}/packages/*`
7574
]);
7675
allModulesLocation = allModulesLocation.filter(path => {
7776
const json = JSON.parse(

scripts/check_changeset.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ async function getDiffData(): Promise<{
7979
changesetFile = changesetMatch[0];
8080
}
8181
// Check for changed files inside package dirs.
82-
const pkgMatch = filename.match('^(packages(-exp)?/[a-zA-Z0-9-]+)/.*');
82+
const pkgMatch = filename.match('^(packages/[a-zA-Z0-9-]+)/.*');
8383
if (pkgMatch && pkgMatch[1]) {
8484
// skip packages without package.json
8585
// It could happen when we rename a package or remove a package from the repo

scripts/exp/docgen.ts

+2-34
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import { spawn } from 'child-process-promise';
1919
import { mapWorkspaceToPackages } from '../release/utils/workspace';
2020
import { projectRoot } from '../utils';
21-
import { removeExpSuffix } from './remove-exp';
2221
import fs from 'fs';
2322
import glob from 'glob';
2423
import * as yargs from 'yargs';
@@ -39,38 +38,10 @@ async function generateDocs(forDevsite: boolean = false) {
3938
const outputFolder = forDevsite ? 'docs-devsite' : 'docs-exp';
4039
const command = forDevsite ? 'api-documenter-devsite' : 'api-documenter';
4140

42-
// TODO: change yarn command once exp packages become official
43-
await spawn('yarn', ['lerna', 'run', '--scope', '@firebase/*-exp', 'build'], {
41+
await spawn('yarn', ['lerna', 'run', '--scope', '@firebase/*', 'build'], {
4442
stdio: 'inherit'
4543
});
4644

47-
// build storage-exp
48-
await spawn(
49-
'yarn',
50-
['lerna', 'run', '--scope', '@firebase/storage', 'build:exp'],
51-
{
52-
stdio: 'inherit'
53-
}
54-
);
55-
56-
// build database-exp
57-
await spawn(
58-
'yarn',
59-
['lerna', 'run', '--scope', '@firebase/database', 'build:exp'],
60-
{
61-
stdio: 'inherit'
62-
}
63-
);
64-
65-
// generate public typings for firestore
66-
await spawn(
67-
'yarn',
68-
['lerna', 'run', '--scope', '@firebase/firestore', 'prebuild'],
69-
{
70-
stdio: 'inherit'
71-
}
72-
);
73-
7445
await spawn('yarn', ['api-report'], {
7546
stdio: 'inherit'
7647
});
@@ -82,8 +53,7 @@ async function generateDocs(forDevsite: boolean = false) {
8253
// TODO: Throw error if path doesn't exist once all packages add markdown support.
8354
const apiJsonDirectories = (
8455
await mapWorkspaceToPackages([
85-
`${projectRoot}/packages/*`,
86-
`${projectRoot}/packages-exp/*`
56+
`${projectRoot}/packages/*`
8757
])
8858
)
8959
.map(path => `${path}/temp`)
@@ -106,8 +76,6 @@ async function generateDocs(forDevsite: boolean = false) {
10676
fs.copyFileSync(paths[0], `${tmpDir}/${fileName}`);
10777
}
10878

109-
// Generate docs without the -exp suffix
110-
removeExpSuffix(tmpDir);
11179
await spawn(
11280
'yarn',
11381
[command, 'markdown', '--input', 'temp', '--output', outputFolder],

scripts/utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export async function getChangedPackages(
4141
const files = changedFiles || (await getChangedFiles());
4242
for (const filename of files) {
4343
// Check for changed files inside package dirs.
44-
const match = filename.match('^(packages(-exp)?/[a-zA-Z0-9-]+)/.*');
44+
const match = filename.match('^(packages/[a-zA-Z0-9-]+)/.*');
4545
if (match && match[1]) {
4646
const changedPackage = require(resolve(
4747
projectRoot,

0 commit comments

Comments
 (0)