Skip to content

Commit feb5038

Browse files
DellaBittaDellaBitta
authored
Update CI node.js versions to 20.x (#8055)
Upgrade our CI scripts and workflows to work in Node 20.x: - Updated workflows to use node 20.x across the board - Updated tests which use the emualtor to connect to '127.0.0.1' explicitly instead of 'localhost', since newer versions of `node` treat `localhost` differently depending on the executing OS. For instance, `localhost` might resolve to the IPv6 address `::1`, but that's not the address that the emulators bind to. - Updated `packages/rules-unit-testing/functions/package.json` `engines` directive to define `>=16` instead of requiring `16` explicitly.
1 parent 245dd26 commit feb5038

31 files changed

+103
-101
lines changed

Diff for: ‎.changeset/violet-ways-judge.md

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

Diff for: ‎.github/workflows/canary-deploy.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
with:
3232
# Canary release script requires git history and tags.
3333
fetch-depth: 0
34-
- name: Set up Node (16)
34+
- name: Set up Node (20)
3535
uses: actions/setup-node@v3
3636
with:
37-
node-version: 16.x
37+
node-version: 20.x
3838
- name: Yarn install
3939
run: yarn
4040
- name: Deploy canary

Diff for: ‎.github/workflows/check-changeset.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434
with:
3535
# This makes Actions fetch all Git history so check_changeset script can diff properly.
3636
fetch-depth: 0
37-
- name: Set up Node (16)
37+
- name: Set up Node (20)
3838
uses: actions/setup-node@v3
3939
with:
40-
node-version: 16.x
40+
node-version: 20.x
4141
- name: Yarn install
4242
run: yarn
4343
- name: Run changeset script

Diff for: ‎.github/workflows/check-docs.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
with:
2828
# get all history for the diff
2929
fetch-depth: 0
30-
- name: Set up Node (16)
30+
- name: Set up Node (20)
3131
uses: actions/setup-node@v3
3232
with:
33-
node-version: 16.x
33+
node-version: 20.x
3434
- name: Yarn install
3535
run: yarn
3636
- name: Run doc generation (devsite docs)

Diff for: ‎.github/workflows/check-pkg-paths.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
with:
2828
# This makes Actions fetch all Git history so run-changed script can diff properly.
2929
fetch-depth: 0
30-
- name: Set up Node (16)
30+
- name: Set up Node (20)
3131
uses: actions/setup-node@v3
3232
with:
33-
node-version: 16.x
33+
node-version: 20.x
3434
- name: Yarn install
3535
run: yarn
3636
- name: Yarn build

Diff for: ‎.github/workflows/deploy-config.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434
with:
3535
# This makes Actions fetch all Git history so run-changed script can diff properly.
3636
fetch-depth: 0
37-
- name: Set up node (18)
37+
- name: Set up node (20)
3838
uses: actions/setup-node@v3
3939
with:
40-
node-version: 18.x
40+
node-version: 20.x
4141
- name: Yarn install
4242
run: yarn
4343
- name: Deploy project config if needed

Diff for: ‎.github/workflows/e2e-test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ jobs:
3636
steps:
3737
- name: Checkout Repo
3838
uses: actions/checkout@master
39-
- name: Set up Node (18)
39+
- name: Set up Node (20)
4040
uses: actions/setup-node@master
4141
with:
42-
node-version: 18.x
42+
node-version: 20.x
4343
- name: install Chrome stable
4444
run: |
4545
sudo apt-get update

Diff for: ‎.github/workflows/format.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
with:
3232
# get all history for the diff
3333
fetch-depth: 0
34-
- name: Set up node (16)
34+
- name: Set up node (20)
3535
uses: actions/setup-node@v3
3636
with:
37-
node-version: 16.x
37+
node-version: 20.x
3838
- name: Yarn install
3939
run: yarn
4040
- name: Run formatting script

Diff for: ‎.github/workflows/health-metrics-pull-request.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
- uses: actions/checkout@v3
4242
- uses: actions/setup-node@v3
4343
with:
44-
node-version: 16.x
44+
node-version: 20.x
4545
- uses: 'google-github-actions/auth@v0'
4646
with:
4747
credentials_json: '${{ secrets.GCP_SA_KEY }}'
@@ -58,7 +58,7 @@ jobs:
5858
- uses: actions/checkout@v3
5959
- uses: actions/setup-node@v3
6060
with:
61-
node-version: 16.x
61+
node-version: 20.x
6262
- uses: 'google-github-actions/auth@v0'
6363
with:
6464
credentials_json: '${{ secrets.GCP_SA_KEY }}'

Diff for: ‎.github/workflows/lint.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ jobs:
2323

2424
steps:
2525
- uses: actions/checkout@v3
26-
- name: Set up node (16)
26+
- name: Set up node (20)
2727
uses: actions/setup-node@v3
2828
with:
29-
node-version: 16.x
29+
node-version: 20.x
3030
- name: yarn install
3131
run: yarn
3232
- name: yarn lint

Diff for: ‎.github/workflows/prerelease-manual-deploy.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434
with:
3535
# Canary release script requires git history and tags.
3636
fetch-depth: 0
37-
- name: Set up node (16)
37+
- name: Set up node (20)
3838
uses: actions/setup-node@v3
3939
with:
40-
node-version: 16.x
40+
node-version: 20.x
4141
- name: Yarn install
4242
run: yarn
4343
- name: Deploy prerelease

Diff for: ‎.github/workflows/release-log.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ jobs:
2828
- name: Checkout Repo
2929
uses: actions/checkout@master
3030

31-
- name: Setup Node.js 16.x
31+
- name: Setup Node.js 20.x
3232
uses: actions/setup-node@master
3333
with:
34-
node-version: 16.x
34+
node-version: 20.x
3535

3636
- name: Get PR number and send to tracker.
3737
run: node scripts/ci/log-changesets.js

Diff for: ‎.github/workflows/release-pr.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ jobs:
3232
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
3333
fetch-depth: 0
3434

35-
- name: Setup Node.js 16.x
35+
- name: Setup Node.js 20.x
3636
uses: actions/setup-node@master
3737
with:
38-
node-version: 16.x
38+
node-version: 20.x
3939

4040
- name: Install Dependencies
4141
run: yarn

Diff for: ‎.github/workflows/release-prod.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ jobs:
3232
contents: write
3333

3434
steps:
35-
- name: Set up node (16)
35+
- name: Set up node (20)
3636
uses: actions/setup-node@v3
3737
with:
38-
node-version: 16.x
38+
node-version: 20.x
3939
- name: Checkout release branch (with history)
4040
uses: actions/checkout@master
4141
with:

Diff for: ‎.github/workflows/release-staging.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ jobs:
4646
# Block this workflow if run on a non-release branch.
4747
if: github.event.inputs.release-branch == 'release' || endsWith(github.event.inputs.release-branch, '-releasebranch')
4848
steps:
49-
- name: Set up node (16)
49+
- name: Set up node (20)
5050
uses: actions/setup-node@v3
5151
with:
52-
node-version: 16.x
52+
node-version: 20.x
5353
- name: Merge master into release
5454
uses: actions/github-script@v6
5555
with:

Diff for: ‎.github/workflows/release-tweet.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434
steps:
3535
- name: Checkout Repo
3636
uses: actions/checkout@master
37-
- name: Setup Node.js 16.x
37+
- name: Setup Node.js 20.x
3838
uses: actions/setup-node@master
3939
with:
40-
node-version: 16.x
40+
node-version: 20.x
4141
- name: Poll release notes page on devsite
4242
run: node scripts/ci/poll_release_notes.js
4343
env:

Diff for: ‎.github/workflows/test-all.yml

+10-10
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ jobs:
4242
run: |
4343
npx @puppeteer/browsers install chrome@stable
4444
- uses: actions/checkout@v3
45-
- name: Set up Node (16)
45+
- name: Set up Node (20)
4646
uses: actions/setup-node@v3
4747
with:
48-
node-version: 16.x
48+
node-version: 20.x
4949
- name: Test setup and yarn install
5050
run: |
5151
cp config/ci.config.json config/project.json
@@ -81,10 +81,10 @@ jobs:
8181
name: build.tar.gz
8282
- name: Unzip build artifact
8383
run: tar xf build.tar.gz
84-
- name: Set up Node (16)
84+
- name: Set up Node (20)
8585
uses: actions/setup-node@v3
8686
with:
87-
node-version: 16.x
87+
node-version: 20.x
8888
- name: Test setup and yarn install
8989
run: |
9090
cp config/ci.config.json config/project.json
@@ -132,10 +132,10 @@ jobs:
132132
name: build.tar.gz
133133
- name: Unzip build artifact
134134
run: tar xf build.tar.gz
135-
- name: Set up Node (16)
135+
- name: Set up Node (20)
136136
uses: actions/setup-node@v3
137137
with:
138-
node-version: 16.x
138+
node-version: 20.x
139139
- name: Test setup and yarn install
140140
run: |
141141
cp config/ci.config.json config/project.json
@@ -175,10 +175,10 @@ jobs:
175175
name: build.tar.gz
176176
- name: Unzip build artifact
177177
run: tar xf build.tar.gz
178-
- name: Set up Node (16)
178+
- name: Set up Node (20)
179179
uses: actions/setup-node@v3
180180
with:
181-
node-version: 16.x
181+
node-version: 20.x
182182
- name: Test setup and yarn install
183183
run: |
184184
cp config/ci.config.json config/project.json
@@ -219,10 +219,10 @@ jobs:
219219
name: build.tar.gz
220220
- name: Unzip build artifact
221221
run: tar xf build.tar.gz
222-
- name: Set up Node (16)
222+
- name: Set up Node (20)
223223
uses: actions/setup-node@v3
224224
with:
225-
node-version: 16.x
225+
node-version: 20.x
226226
- run: cp config/ci.config.json config/project.json
227227
- run: yarn
228228
- run: yarn build:${{ matrix.persistence }}

Diff for: ‎.github/workflows/test-changed-auth.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ jobs:
5656
with:
5757
# This makes Actions fetch all Git history so run-changed script can diff properly.
5858
fetch-depth: 0
59-
- name: Set up Node (16)
59+
- name: Set up Node (20)
6060
uses: actions/setup-node@v3
6161
with:
62-
node-version: 16.x
62+
node-version: 20.x
6363
- name: Test setup and yarn install
6464
run: |
6565
cp config/ci.config.json config/project.json
@@ -88,10 +88,10 @@ jobs:
8888
with:
8989
# This makes Actions fetch all Git history so run-changed script can diff properly.
9090
fetch-depth: 0
91-
- name: Set up Node (16)
91+
- name: Set up Node (20)
9292
uses: actions/setup-node@v3
9393
with:
94-
node-version: 16.x
94+
node-version: 20.x
9595
- name: Test setup and yarn install
9696
run: |
9797
cp config/ci.config.json config/project.json

Diff for: ‎.github/workflows/test-changed-fcm-integration.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ jobs:
3838
with:
3939
# This makes Actions fetch all Git history so run-changed script can diff properly.
4040
fetch-depth: 0
41-
- name: Set up Node (16)
41+
- name: Set up Node (20)
4242
uses: actions/setup-node@v3
4343
with:
44-
node-version: 16.x
44+
node-version: 20.x
4545
- name: Test setup and yarn install
4646
run: |
4747
cp config/ci.config.json config/project.json

Diff for: ‎.github/workflows/test-changed-firestore-integration.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ jobs:
6363
rm -f "$output_file"
6464
continue-on-error: true
6565

66-
- name: Set up Node (16)
66+
- name: Set up Node (20)
6767
uses: actions/setup-node@v3
6868
with:
69-
node-version: 16.x
69+
node-version: 20.x
7070
- name: install Chrome stable
7171
run: |
7272
sudo apt-get update

Diff for: ‎.github/workflows/test-changed-firestore.yml

+12-12
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ jobs:
3737
with:
3838
# This makes Actions fetch all Git history so run-changed script can diff properly.
3939
fetch-depth: 0
40-
- name: Set up Node (16)
40+
- name: Set up Node (20)
4141
uses: actions/setup-node@v3
4242
with:
43-
node-version: 16.x
43+
node-version: 20.x
4444
- name: install Chrome stable
4545
run: |
4646
sudo apt-get update
@@ -84,10 +84,10 @@ jobs:
8484
needs: build
8585
if: ${{ needs.build.outputs.changed == 'true'}}
8686
steps:
87-
- name: Set up Node (16)
87+
- name: Set up Node (20)
8888
uses: actions/setup-node@v3
8989
with:
90-
node-version: 16.x
90+
node-version: 20.x
9191
- name: install Chrome stable
9292
run: |
9393
sudo apt-get update
@@ -112,10 +112,10 @@ jobs:
112112
needs: build
113113
if: ${{ needs.build.outputs.changed == 'true'}}
114114
steps:
115-
- name: Set up Node (16)
115+
- name: Set up Node (20)
116116
uses: actions/setup-node@v3
117117
with:
118-
node-version: 16.x
118+
node-version: 20.x
119119
- name: install Chrome stable
120120
run: |
121121
sudo apt-get update
@@ -142,10 +142,10 @@ jobs:
142142
needs: build
143143
if: ${{ github.event_name != 'pull_request' }}
144144
steps:
145-
- name: Set up Node (16)
145+
- name: Set up Node (20)
146146
uses: actions/setup-node@v3
147147
with:
148-
node-version: 16.x
148+
node-version: 20.x
149149
- name: install Chrome stable
150150
run: |
151151
sudo apt-get update
@@ -180,10 +180,10 @@ jobs:
180180
run: |
181181
sudo apt-get update
182182
sudo apt-get install firefox
183-
- name: Set up Node (16)
183+
- name: Set up Node (20)
184184
uses: actions/setup-node@v3
185185
with:
186-
node-version: 16.x
186+
node-version: 20.x
187187
- name: Download build archive
188188
uses: actions/download-artifact@v3
189189
with:
@@ -219,10 +219,10 @@ jobs:
219219
name: build.tar.gz
220220
- name: Unzip build artifact
221221
run: tar xf build.tar.gz
222-
- name: Set up Node (16)
222+
- name: Set up Node (20)
223223
uses: actions/setup-node@v3
224224
with:
225-
node-version: 16.x
225+
node-version: 20.x
226226
- name: Test setup and yarn install
227227
run: cp config/ci.config.json config/project.json
228228
- name: Run tests

0 commit comments

Comments
 (0)