Skip to content

Reference docs on DeltaDocumentSnapshot data method is incorrect #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x80 opened this issue Nov 22, 2017 · 4 comments
Closed

Reference docs on DeltaDocumentSnapshot data method is incorrect #330

0x80 opened this issue Nov 22, 2017 · 4 comments

Comments

@0x80
Copy link

0x80 commented Nov 22, 2017

In the reference docs it says that the DeltaDocumentSnapshot data method returns a DeltaDocumentSnapshot.

The text is correct I guess, just not the return type. According to the source code it is any.

@google-oss-bot
Copy link
Contributor

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@google-oss-bot
Copy link
Contributor

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@rockwotj
Copy link
Contributor

Hello, thanks for bringing this up! I believe you are referring to the functions code found here: https://github.com/firebase/firebase-functions/blob/master/src/providers/firestore.ts#L79

If that's it would you mind opening the issue in that repo and closing this one? Thanks!

@laurenzlong
Copy link

It's actually an issue with the functions docs, closing this bug.

@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants