From 0aeda3c83bb62da471a82383e73ee36c9ba3b55d Mon Sep 17 00:00:00 2001 From: Sam Olsen Date: Tue, 21 Sep 2021 10:16:54 -0700 Subject: [PATCH 1/3] Make the persistences default to inMemory for node --- packages/auth/src/platform_node/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/auth/src/platform_node/index.ts b/packages/auth/src/platform_node/index.ts index dbb0239a431..14f5a531b93 100644 --- a/packages/auth/src/platform_node/index.ts +++ b/packages/auth/src/platform_node/index.ts @@ -21,7 +21,7 @@ import { _createError } from '../core/util/assert'; import { FirebaseApp, getApp, _getProvider } from '@firebase/app'; import { Auth } from '../model/public_types'; -import { initializeAuth } from '..'; +import { initializeAuth, inMemoryPersistence } from '..'; import { registerAuth } from '../core/auth/register'; import { ClientPlatform } from '../core/util/version'; import { AuthImpl } from '../core/auth/auth_impl'; @@ -76,9 +76,9 @@ class FailClass { } } -export const browserLocalPersistence = NOT_AVAILABLE_ERROR; -export const browserSessionPersistence = NOT_AVAILABLE_ERROR; -export const indexedDBLocalPersistence = NOT_AVAILABLE_ERROR; +export const browserLocalPersistence = inMemoryPersistence; +export const browserSessionPersistence = inMemoryPersistence; +export const indexedDBLocalPersistence = inMemoryPersistence; export const browserPopupRedirectResolver = NOT_AVAILABLE_ERROR; export const PhoneAuthProvider = FailClass; export const signInWithPhoneNumber = fail; From a987c94fa3db019d569affec341be8eb4af55c05 Mon Sep 17 00:00:00 2001 From: Sam Date: Tue, 21 Sep 2021 10:18:54 -0700 Subject: [PATCH 2/3] Add changeset --- .changeset/swift-shirts-appear.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/swift-shirts-appear.md diff --git a/.changeset/swift-shirts-appear.md b/.changeset/swift-shirts-appear.md new file mode 100644 index 00000000000..bdbfa3a1957 --- /dev/null +++ b/.changeset/swift-shirts-appear.md @@ -0,0 +1,5 @@ +--- +"@firebase/auth": patch +--- + +Update all persistences to map to `inMemoryPersistence` in Node, to avoid errors with server-side rendering From 1baa76175a0b3d8febc3aea94d75f1b009196119 Mon Sep 17 00:00:00 2001 From: Sam Date: Tue, 21 Sep 2021 10:26:42 -0700 Subject: [PATCH 3/3] Update changeset to be "minor" instead of "patch" --- .changeset/swift-shirts-appear.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/swift-shirts-appear.md b/.changeset/swift-shirts-appear.md index bdbfa3a1957..b2da4b471a9 100644 --- a/.changeset/swift-shirts-appear.md +++ b/.changeset/swift-shirts-appear.md @@ -1,5 +1,5 @@ --- -"@firebase/auth": patch +"@firebase/auth": minor --- Update all persistences to map to `inMemoryPersistence` in Node, to avoid errors with server-side rendering