Skip to content

Commit 33d5b9b

Browse files
committed
Missed a spot.
1 parent d1931ea commit 33d5b9b

File tree

1 file changed

+12
-1
lines changed
  • src/init/features/frameworks

1 file changed

+12
-1
lines changed

src/init/features/frameworks/repo.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,17 @@ async function promptRepositoryUri(
163163
async function promptSecretManagerAdminGrant(projectId: string): Promise<Boolean> {
164164
const projectNumber = await getProjectNumber({ projectId });
165165
const cbsaEmail = gcb.serviceAgentEmail(projectNumber);
166+
167+
const alreadyGranted = await rm.serviceAccountHasRoles(
168+
projectId,
169+
cbsaEmail,
170+
["roles/secretmanager.admin"],
171+
true
172+
);
173+
if (alreadyGranted) {
174+
return true;
175+
}
176+
166177
utils.logBullet(
167178
"To create a new GitHub connection, Secret Manager Admin role (roles/secretmanager.admin) is required on the Cloud Build Service Agent."
168179
);
@@ -205,7 +216,7 @@ async function promptConnectionAuth(conn: gcb.Connection): Promise<gcb.Connectio
205216
async function promptAppInstall(conn: gcb.Connection): Promise<gcb.Connection> {
206217
utils.logBullet("Now, install the Cloud Build GitHub app:");
207218
const targetUri = conn.installationState.actionUri.replace("install_v2", "direct_install_v2");
208-
utils.logBullet(targetUri);
219+
utils.logBullet(`\t${targetUri}`);
209220
await utils.openInBrowser(targetUri);
210221
await promptOnce({
211222
type: "input",

0 commit comments

Comments
 (0)