Skip to content

Commit 6a33688

Browse files
authored
Update min node version to 18, add 20 to supported versions & CI (#6447)
* Update min node version to 18, add 20 to supported versions & CI * Fix broken unit test * Bump dockefiles to Node 20 as well
1 parent 2b855f9 commit 6a33688

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

scripts/build/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:18
1+
FROM node:20
22

33
# Install dependencies
44
RUN apt-get update && \

scripts/firepit-builder/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:18
1+
FROM node:20
22

33
# Install dependencies
44
RUN apt-get update && \

src/test/apiv2.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ describe("apiv2", () => {
158158
method: "GET",
159159
path: "/path/to/foo",
160160
});
161-
await expect(r).to.eventually.be.rejectedWith(FirebaseError, /Unexpected token.+JSON/);
161+
await expect(r).to.eventually.be.rejectedWith(FirebaseError, /Unable to parse JSON/);
162162
expect(nock.isDone()).to.be.true;
163163
});
164164

0 commit comments

Comments
 (0)