Skip to content

Commit c94dca4

Browse files
joehanFerido07
andauthored
Fix Issue #6382 Firebase not working for NextJs >=v13.5.0 (#6404)
* Fix Issue #6382 Firebase not working for NextJs >=v13.5.0 Fixes #6382 Due to braking changes on the signature of loadConfig (https://github.com/vercel/next.js/blob/d96e0258de2caf34e9322d0d32ab5748533c4465/packages/next/src/server/config.ts#L784) Firebase does not deploy correctly. * Changelog --------- Co-authored-by: Ferid Zuber <[email protected]>
1 parent d04add6 commit c94dca4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
- Improve performance and reliability when deploying multiple 2nd gen functions using single builds. (#6376)
22
- Fixed an issue where `emulators:export` did not check if the target folder is empty. (#6313)
3-
- Fix "Could not find the next executable" on Next.js deployments (#6372)
3+
- Fixed "Could not find the next executable" on Next.js deployments (#6372)
4+
- Fixed issues caused by breaking changes in Next >=v13.5.0. (#6382)

src/frameworks/next/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ async function getConfig(
594594
if (gte(version, "12.0.0")) {
595595
const { default: loadConfig } = relativeRequire(dir, "next/dist/server/config");
596596
const { PHASE_PRODUCTION_BUILD } = relativeRequire(dir, "next/constants");
597-
config = await loadConfig(PHASE_PRODUCTION_BUILD, dir, null);
597+
config = await loadConfig(PHASE_PRODUCTION_BUILD, dir);
598598
} else {
599599
try {
600600
config = await import(pathToFileURL(join(dir, "next.config.js")).toString());

0 commit comments

Comments
 (0)