Only fail spinners if they are spinning (#1860)

* only fails spinners if they are spinning

* adds changleog entry

Author: joehan

CHANGELOG.md

@@ -0,0 +1 @@
+* Clean up extraneous error messages in extensions commands.

src/commands/ext-configure.ts

@@ -89,7 +89,9 @@ export default new Command("ext:configure <extensionInstanceId>")
       );
       return res;
     } catch (err) {
-      spinner.fail();
+      if (spinner.isSpinning) {
+        spinner.fail();
+      }
       if (!(err instanceof FirebaseError)) {
         throw new FirebaseError(`Error occurred while configuring the instance: ${err.message}`, {
           original: err,

src/commands/ext-install.ts

@@ -101,7 +101,9 @@ async function installExtension(options: InstallExtensionOptions): Promise<void>
       )
     );
   } catch (err) {
-    spinner.fail();
+    if (spinner.isSpinning) {
+      spinner.fail();
+    }
     if (err instanceof FirebaseError) {
       throw err;
     }

src/commands/ext-uninstall.ts

@@ -97,7 +97,9 @@ export default new Command("ext:uninstall <extensionInstanceId>")
         }
       }
     } catch (err) {
-      spinner.fail();
+      if (spinner.isSpinning) {
+        spinner.fail();
+      }
       if (err instanceof FirebaseError) {
         throw err;
       }