Skip to content

Commit eeccd95

Browse files
committed
Finishing touches on the logged messages.
1 parent cd5bd60 commit eeccd95

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/init/features/frameworks/index.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ export async function doSetup(setup: any, projectId: string): Promise<void> {
5454
const backend: Backend | undefined = await getOrCreateBackend(projectId, setup);
5555

5656
if (backend) {
57-
logSuccess(`Successfully created backend:\n ${backend.name}`);
58-
logSuccess(`Your site is being deployed at:\n https://${backend.uri}\n`);
57+
logSuccess(`Successfully created backend:\n\t${backend.name}`);
58+
logSuccess(`Your site is being deployed at:\n\thttps://${backend.uri}`);
5959
logSuccess(
60-
`View the rollout status by running:\n firebase backends:get --backend=${backend.name}\n`
60+
`View the rollout status by running:\n\tfirebase backends:get --backend=${backend.name}`
6161
);
6262
}
6363
}
@@ -96,7 +96,6 @@ export async function getOrCreateBackend(
9696
setup.frameworks
9797
);
9898
const backendDetails = toBackend(cloudBuildConnRepo);
99-
logBullet(clc.bold(`${clc.white("===")} Creating your backend`));
10099
return await createBackend(projectId, location, backendDetails, setup.frameworks.serviceName);
101100
} else {
102101
throw new FirebaseError(

src/init/features/frameworks/repo.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export async function linkGitHubRepository(
7979
projectId: string,
8080
location: string
8181
): Promise<gcb.Repository> {
82-
utils.logBullet(clc.bold(`${clc.yellow("===")} Connect a GitHub repository`));
82+
utils.logBullet(clc.bold(`${clc.yellow("===")} Set up a GitHub connection`));
8383
const existingConns = await listFrameworksConnections(projectId);
8484
if (existingConns.length < 1) {
8585
const grantSuccess = await promptSecretManagerAdminGrant(projectId);
@@ -123,7 +123,8 @@ export async function linkGitHubRepository(
123123
appInstallationId: connection.githubConfig?.appInstallationId,
124124
});
125125
const repo = await getOrCreateRepository(projectId, location, connectionId, remoteUri);
126-
utils.logSuccess(`Successfully linked GitHub repository at remote URI:\n ${remoteUri}`);
126+
utils.logSuccess(`Successfully linked GitHub repository at remote URI`);
127+
utils.logSuccess(`\t${remoteUri}`);
127128
return repo;
128129
}
129130

@@ -197,13 +198,13 @@ async function promptSecretManagerAdminGrant(projectId: string): Promise<Boolean
197198
}
198199

199200
async function promptConnectionAuth(conn: gcb.Connection): Promise<gcb.Connection> {
200-
utils.logBullet("You must authorize the Cloud Build GitHub app.\n");
201+
utils.logBullet("You must authorize the Cloud Build GitHub app.");
201202
utils.logBullet("Sign in to GitHub and authorize Cloud Build GitHub app:");
202203
const { url, cleanup } = await utils.openInBrowserPopup(
203204
conn.installationState.actionUri,
204205
"Authorize the GitHub app"
205206
);
206-
utils.logBullet(`\t${url}\n`);
207+
utils.logBullet(`\t${url}`);
207208
await promptOnce({
208209
type: "input",
209210
message: "Press Enter once you have authorized the app",
@@ -214,9 +215,9 @@ async function promptConnectionAuth(conn: gcb.Connection): Promise<gcb.Connectio
214215
}
215216

216217
async function promptAppInstall(conn: gcb.Connection): Promise<gcb.Connection> {
217-
utils.logBullet("Now, install the Cloud Build GitHub app:");
218+
utils.logBullet("Install the Cloud Build GitHub app to enable access to GitHub repositories");
218219
const targetUri = conn.installationState.actionUri.replace("install_v2", "direct_install_v2");
219-
utils.logBullet(`\t${targetUri}`);
220+
utils.logBullet(targetUri);
220221
await utils.openInBrowser(targetUri);
221222
await promptOnce({
222223
type: "input",

0 commit comments

Comments
 (0)