Skip to content

Commit a685929

Browse files
authored
Merge pull request #43 from firebase/am-mac-fixes
Remove swig update logic, add openssl, and fix iOS packaging
2 parents a589337 + 04c7689 commit a685929

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed

.github/workflows/sdk_build.yml

+11-14
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,6 @@ jobs:
7070
python scripts/gha/install_prereqs_desktop.py
7171
cd ..
7272
73-
- name: Install swig (Linux)
74-
if: startsWith(matrix.os, 'ubuntu')
75-
run: |
76-
sudo apt-get remove -y swig
77-
sudo apt-get remove -y swig4.0
78-
sudo apt-get install -y swig3.0
79-
alias swig='swig3.0'
80-
81-
# TODO: Change the swig versions installed on Mac and Windows
82-
- name: Install swig (Mac & Windows)
83-
if: startsWith(matrix.os, 'macos') || startsWith(matrix.os, 'windows')
84-
run: |
85-
swig -version
86-
8773
# Set up the requirements, and install Unity
8874
- uses: ruby/setup-ruby@v1
8975
with:
@@ -104,6 +90,17 @@ jobs:
10490
run: |
10591
echo "UNITY_ROOT_DIR=${{ matrix.unity_install_dir }}" >> $GITHUB_ENV
10692
93+
- name: Install OpenSSL (Linux)
94+
if: startsWith(matrix.os, 'ubuntu')
95+
run: |
96+
sudo apt install openssl
97+
- name: Install OpenSSL (macOS)
98+
if: startsWith(matrix.os, 'macos')
99+
run: |
100+
brew install openssl
101+
# brew won't overwrite MacOS system default OpenSSL, so force it here.
102+
echo "OPENSSL_ROOT_DIR=$(brew --prefix openssl --installed)" >> $GITHUB_ENV
103+
107104
- name: Build SDK (Linux)
108105
if: startsWith(matrix.os, 'ubuntu')
109106
shell: bash

external/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717

1818
mono_add_external_dll(unity_editor_cs "${UNITY_EDITOR_DLL}")
1919
mono_add_external_dll(unity_engine_cs "${UNITY_ENGINE_DLL}")
20-
if(APPLE)
20+
if(FIREBASE_IOS_BUILD)
2121
mono_add_external_dll(unity_ios_extensions_xcode_cs "${UNITY_EDITOR_IOS_XCODE_DLL}")
2222
endif()
2323

2424
# Dont pack libraries shipped with unity
2525
unity_pack_skip(unity_editor_cs)
2626
unity_pack_skip(unity_engine_cs)
27-
if(APPLE)
27+
if(FIREBASE_IOS_BUILD)
2828
unity_pack_skip(unity_ios_extensions_xcode_cs)
2929
endif()
3030

0 commit comments

Comments
 (0)