Skip to content

Commit 52e9595

Browse files
committed
chore(ui): fix e2e tests
1 parent 8320499 commit 52e9595

6 files changed

+22
-8
lines changed

Diff for: packages/firebase_ui_auth/example/test_driver/email_form_test.dart

+1
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ void main() {
116116
await tester.testTextInput.receiveAction(TextInputAction.done);
117117

118118
await tester.pump();
119+
await Future.delayed(const Duration(milliseconds: 1));
119120

120121
expect(find.byType(LoadingIndicator), findsOneWidget);
121122
await tester.pumpAndSettle();

Diff for: packages/firebase_ui_auth/example/test_driver/flutterfire_ui_e2e.dart renamed to packages/firebase_ui_auth/example/test_driver/firebase_ui_auth_e2e.dart

+8-5
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@ Future<void> main() async {
3030
email_form.main();
3131
email_link_sign_in_view.main();
3232
universal_email_sign_in_screen.main();
33-
phone_verification.main();
34-
google_sign_in.main();
35-
twitter_sign_in.main();
36-
apple_sign_in.main();
37-
facebook_sign_in.main();
33+
34+
if (isMobile) {
35+
phone_verification.main();
36+
google_sign_in.main();
37+
twitter_sign_in.main();
38+
apple_sign_in.main();
39+
facebook_sign_in.main();
40+
}
3841
}

Diff for: packages/firebase_ui_auth/example/test_driver/phone_verification_test.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import 'dart:async';
22

3-
import 'package:flutter/foundation.dart';
43
import 'package:flutter/material.dart';
54
import 'package:flutter_test/flutter_test.dart';
65
import 'package:firebase_ui_auth/firebase_ui_auth.dart';
@@ -20,6 +19,7 @@ Future<void> sendSMS(WidgetTester tester, String phoneNumber) async {
2019

2120
void main() {
2221
const labels = DefaultLocalizations();
22+
2323
group('PhoneInputScreen', () {
2424
testWidgets(
2525
'allows to pick country code',
@@ -195,5 +195,5 @@ void main() {
195195
expect(state.user!.phoneNumber, '+1234567890');
196196
},
197197
);
198-
}, skip: kIsWeb);
198+
});
199199
}

Diff for: packages/firebase_ui_auth/example/test_driver/universal_email_sign_in_screen_test.dart

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:firebase_auth/firebase_auth.dart'
22
hide EmailAuthProvider, PhoneAuthProvider;
33
import 'package:firebase_core/firebase_core.dart';
4+
import 'package:flutter/foundation.dart';
45
import 'package:flutter/material.dart';
56
import 'package:flutter_test/flutter_test.dart';
67
import 'package:firebase_ui_auth/firebase_ui_auth.dart';
@@ -89,7 +90,10 @@ void main() {
8990
await tester.pumpAndSettle();
9091

9192
expect(find.byType(SignInScreen), findsOneWidget);
92-
expect(find.text(labels.signInWithPhoneButtonText), findsOneWidget);
93+
94+
if (PhoneAuthProvider().supportsPlatform(defaultTargetPlatform)) {
95+
expect(find.text(labels.signInWithPhoneButtonText), findsOneWidget);
96+
}
9397
expect(find.text(labels.signInWithGoogleButtonText), findsOneWidget);
9498
expect(find.byType(EmailForm), findsNothing);
9599
});

Diff for: packages/firebase_ui_auth/example/test_driver/utils.dart

+6
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ String get testEmulatorHost {
1616
return 'localhost';
1717
}
1818

19+
bool get isMobile {
20+
return !kIsWeb &&
21+
(defaultTargetPlatform == TargetPlatform.iOS ||
22+
defaultTargetPlatform == TargetPlatform.android);
23+
}
24+
1925
Future<void> prepare() async {
2026
await Firebase.initializeApp(options: DefaultFirebaseOptions.currentPlatform);
2127
await FirebaseAuth.instance.useAuthEmulator(testEmulatorHost, 9099);

0 commit comments

Comments
 (0)