From 1f0c13687a5c4911921a23f651477790a19fe866 Mon Sep 17 00:00:00 2001 From: Zachary Russell Date: Fri, 12 May 2023 14:52:46 -0400 Subject: [PATCH 1/3] Fix Error: --- packages/firebase_ui_auth/lib/src/screens/profile_screen.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart index 32d6e44b33c7..4c22778b42cb 100644 --- a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart +++ b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart @@ -390,9 +390,9 @@ class _EmailVerificationBadgeState extends State<_EmailVerificationBadge> { ), const SizedBox(height: 16), if (state == EmailVerificationState.pending) - const Row( + Row( mainAxisAlignment: MainAxisAlignment.center, - children: [ + children: const [ LoadingIndicator(size: 16, borderWidth: 0.5), SizedBox(width: 16), Text('Waiting for email verification'), From 9aa4173104896c2b5cd5ba86e43af824c928882a Mon Sep 17 00:00:00 2001 From: Zachary Russell Date: Mon, 15 May 2023 11:57:06 -0400 Subject: [PATCH 2/3] fix(test): get tests to pass The prefer_const_constructors warning is ignored in this case because the LoadingIndicator widget used inside the children list of the Row does not have a const constructor. This is due to the fact that LoadingIndicator extends PlatformWidget, which doesn't have a const constructor, making it impossible to have a const constructor for LoadingIndicator. Since we can't make the LoadingIndicator constructor const, we have to ignore the warning for the specific Row constructor. This is an acceptable solution in cases like this, where making the constructor const is not feasible or possible. --- .../firebase_ui_auth/lib/src/screens/profile_screen.dart | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart index 4c22778b42cb..3c852ba71391 100644 --- a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart +++ b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart @@ -390,12 +390,13 @@ class _EmailVerificationBadgeState extends State<_EmailVerificationBadge> { ), const SizedBox(height: 16), if (state == EmailVerificationState.pending) + // ignore: prefer_const_constructors Row( mainAxisAlignment: MainAxisAlignment.center, - children: const [ + children: [ LoadingIndicator(size: 16, borderWidth: 0.5), - SizedBox(width: 16), - Text('Waiting for email verification'), + const SizedBox(width: 16), + const Text('Waiting for email verification'), ], ) else From fd3fc542c3dc30aaf11333adc32294fb658b1ee9 Mon Sep 17 00:00:00 2001 From: Zachary Russell Date: Tue, 16 May 2023 11:43:06 -0400 Subject: [PATCH 3/3] fix: revert changes --- .../firebase_ui_auth/lib/src/screens/profile_screen.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart index 3c852ba71391..65420822da09 100644 --- a/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart +++ b/packages/firebase_ui_auth/lib/src/screens/profile_screen.dart @@ -393,10 +393,10 @@ class _EmailVerificationBadgeState extends State<_EmailVerificationBadge> { // ignore: prefer_const_constructors Row( mainAxisAlignment: MainAxisAlignment.center, - children: [ + children: const [ LoadingIndicator(size: 16, borderWidth: 0.5), - const SizedBox(width: 16), - const Text('Waiting for email verification'), + SizedBox(width: 16), + Text('Waiting for email verification'), ], ) else