Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Utils.expandVariables should be pure and should not modify it's input #1488

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: Utils.expandVariables should be pure and should not modify it's input #1488

merged 1 commit into from
Feb 18, 2025

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Feb 1, 2025 •
edited
Loading

partially fixes #1473 (The RELEASE variable does not propagate properly. issue)

fixes #1492

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firecow firecow merged commit 5f92c0c into master Feb 18, 2025
11 checks passed
@firecow firecow deleted the fix/Utils.expandVariables-should-be-pure-and-should-not-modify-it's-input branch February 18, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firecow firecow firecow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ANGkeith @firecow