Skip to content

Regenerate files needed for configuring an x86_64 system #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dianpopa opened this issue Dec 10, 2018 · 2 comments
Closed

Regenerate files needed for configuring an x86_64 system #755

dianpopa opened this issue Dec 10, 2018 · 2 comments
Assignees
@dianpopa
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `

Comments

@dianpopa
Copy link
Contributor

The bindgened files needed for doing x86_64 specific configuration (bootparam.rs, mpspec.rs, msr_index.rs) are autogenerated from committ 806276b7f07a39a1cc3f38bb1ef5c573d4594a38 of the linux kernel. That corresponds to 4.11. We should auto generate them from the 4.14 release. Make sure we also add PartialEq as a trait.
@dianpopa dianpopa self-assigned this Dec 10, 2018
@raduweiss raduweiss mentioned this issue Dec 10, 2018
Closed
8 tasks
@dianpopa
Copy link
Contributor Author

When making this crate public, this issue will/should be solved.

@raduweiss raduweiss modified the milestone: ARM Support Feb 15, 2019
@dianpopa dianpopa removed this from the ARM Support milestone Mar 15, 2019
@alxiord alxiord added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label Apr 8, 2019
@dianpopa
Copy link
Contributor Author

No need for this anymore. Ideally we should try to move away from using autogenerated code since it adds a lot of mess and not a lot of this autogenerated code is actually used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianpopa dianpopa

Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alxiord @dianpopa @raduweiss