Move generated code to directories with _gen suffix #676
Conversation
|
@sejr you might have noticed that you can't access the test fail error. Sorry about that! We're still working to make those logs public. Until then, the integration tests we run are exactly the ones you can run with |
|
@sejr your PR does not pass the build as there are dependencies in the code where you did not use the newly updated name of the crates. For example, this file still looks for |
|
@raduweiss Thank you for clarifying! |
|
Hey, the changes look good, but can you please squash your commits? We want each individual commit on the master branch to build and pass the unit tests. |
There was a problem hiding this comment.
@sejr changes look good, thanks for the PR! Please address @andreeaflorescu's comment and squash your commits.
sejr
force-pushed
the
move-gen-code
branch
2 times, most recently
from
668cd66 to
632824b
Compare
|
@acatangiu @andreeaflorescu Commits have been squashed. |
kvm_gen/src/x86/bindings.rs
Outdated
| pub const KVM_SYSTEM_EVENT_SHUTDOWN: ::std::os::raw::c_uint = 1; | ||
| pub const KVM_SYSTEM_EVENT_RESET: ::std::os::raw::c_uint = 2; | ||
| pub const KVM_SYSTEM_EVENT_CRASH: ::std::os::raw::c_uint = 3; | ||
| pub const kvm_genTEM_EVENT_SHUTDOWN: ::std::os::raw::c_uint = 1; |
There was a problem hiding this comment.
It looks like these lines were affected by some sort of find/replace collateral damage.
kvm_gen/src/x86/bindings.rs
Outdated
| pub const KVM_SYSTEM_EVENT_SHUTDOWN: ::std::os::raw::c_uint = 1; | ||
| pub const KVM_SYSTEM_EVENT_RESET: ::std::os::raw::c_uint = 2; | ||
| pub const KVM_SYSTEM_EVENT_CRASH: ::std::os::raw::c_uint = 3; | ||
| pub const kvm_genTEM_EVENT_SHUTDOWN: ::std::os::raw::c_uint = 1; |
Signed-off-by: Sam Jackson <[email protected]> Changed references to *_sys crates with corresponding *_gen names Fixed minor typo after find+replace
This PR addresses issue #602.
cc @andreeaflorescu