Rollup merge of rust-lang#114014 - davidtwco:issue-114010-env-rawstr, r=cjgillot

matthiaskrgr · web-flow · commit 0f3a149dc826 · 2023-07-25T19:21:37.000+02:00
builtin_macros: expect raw strings too Fixes rust-lang#114010. `expr_to_string` allows raw strings through so this code should be expected to handle those.
diff --git a/clippy_lints/src/strings.rs b/clippy_lints/src/strings.rs
@@ -328,7 +328,7 @@ impl<'tcx> LateLintPass<'tcx> for StringLitAsBytes {
                     {
                         // Don't lint. Byte strings produce `&[u8; N]` whereas `as_bytes()` produces
                         // `&[u8]`. This change would prevent matching with different sized slices.
-                    } else {
+                    } else if !callsite.starts_with("env!") {
                         span_lint_and_sugg(
                             cx,
                             STRING_LIT_AS_BYTES,

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ impl<'tcx> LateLintPass<'tcx> for StringLitAsBytes {`
`328`	`328`	`{`
`329`	`329`	// Don't lint. Byte strings produce `&[u8; N]` whereas `as_bytes()` produces
`330`	`330`	// `&[u8]`. This change would prevent matching with different sized slices.
`331`		`- } else {`
	`331`	`+ } else if !callsite.starts_with("env!") {`
`332`	`332`	`span_lint_and_sugg(`
`333`	`333`	`cx,`
`334`	`334`	`STRING_LIT_AS_BYTES,`