Skip to content

Commit 87c9343

Browse files
Yeaseenflovent
authored andcommitted
[llvm] Remove br i1 undef in some llvm/test/CodeGen tests (llvm#126811)
This PR replaces some instances of `br i1 undef` with function argument value in several tests under `llvm/test/CodeGen/` directory.
1 parent 9f7d607 commit 87c9343

15 files changed

+40
-40
lines changed

llvm/test/CodeGen/X86/coalescer-subreg.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
; the sub_8bit_hi subregister with a class like GR16_ABCD that did.
44
target triple = "x86_64-apple-macosx10.10.0"
55

6-
define void @test() #0 {
6+
define void @test(i1 %arg) #0 {
77
entry:
8-
br i1 undef, label %loop, label %for.end597
8+
br i1 %arg, label %loop, label %for.end597
99

1010
loop:
1111
%0 = load i16, ptr null, align 4

llvm/test/CodeGen/X86/code_placement_eh.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128-n8:16:32"
77
target triple = "i386-apple-darwin10.0"
88

9-
define void @foo() personality ptr @__gxx_personality_v0 {
9+
define void @foo(i1 %arg) personality ptr @__gxx_personality_v0 {
1010
invcont5:
1111
br label %bb15
1212

1313
.noexc3: ; preds = %bb15
14-
br i1 undef, label %bb18.i5.i, label %bb15
14+
br i1 %arg, label %bb18.i5.i, label %bb15
1515

1616
.noexc6.i.i: ; preds = %bb18.i5.i
1717
%tmp2021 = invoke float @cosf(float 0.000000e+00) readonly

llvm/test/CodeGen/X86/codegen-prepare-cast.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ target triple = "x86_64-unknown-linux-gnu"
1212
; CHECK-LABEL: @_Dmain
1313
; CHECK: load i8, ptr %tmp4
1414
; CHECK: ret
15-
define fastcc i32 @_Dmain(%"char[][]" %unnamed) {
15+
define fastcc i32 @_Dmain(%"char[][]" %unnamed, i1 %arg) {
1616
entry:
1717
%tmp = getelementptr [7 x i8], ptr @.str, i32 0, i32 0 ; <ptr> [#uses=1]
18-
br i1 undef, label %foreachbody, label %foreachend
18+
br i1 %arg, label %foreachbody, label %foreachend
1919

2020
foreachbody: ; preds = %entry
2121
%tmp4 = getelementptr i8, ptr %tmp, i32 undef ; <ptr> [#uses=1]

llvm/test/CodeGen/X86/discontiguous-loops.ll

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
@.str96 = external constant [37 x i8], align 8 ; <ptr> [#uses=1]
55

6-
define void @foo() nounwind {
6+
define void @foo(i1 %arg) nounwind {
77
bb:
88
br label %ybb1
99

@@ -24,7 +24,7 @@ bb3: ; preds = %ybb2
2424

2525
xbb4: ; preds = %xbb6
2626
store i32 0, ptr undef, align 8
27-
br i1 undef, label %xbb6, label %bb5
27+
br i1 %arg, label %xbb6, label %bb5
2828

2929
bb5: ; preds = %xbb4
3030
call fastcc void @decl_mode_check_failed() nounwind
@@ -44,7 +44,7 @@ bb10: ; preds = %ybb8
4444
unreachable
4545

4646
ybb12: ; preds = %ybb8
47-
br i1 undef, label %bb15, label %ybb13
47+
br i1 %arg, label %bb15, label %ybb13
4848

4949
ybb13: ; preds = %ybb12
5050
%tmp14 = icmp sgt i32 undef, 0 ; <i1> [#uses=1]

llvm/test/CodeGen/X86/early-ifcvt-crash.ll

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ target triple = "x86_64-apple-macosx10.8.0"
1010
; MachineTraceMetrics::Ensemble::addLiveIns crashes because the first operand
1111
; on an inline asm instruction is not a vreg def.
1212
; <rdar://problem/12472811>
13-
define void @f1() nounwind {
13+
define void @f1(i1 %arg) nounwind {
1414
entry:
15-
br i1 undef, label %if.then6.i, label %if.end.i
15+
br i1 %arg, label %if.then6.i, label %if.end.i
1616

1717
if.then6.i:
1818
br label %if.end.i
1919

2020
if.end.i:
21-
br i1 undef, label %if.end25.i, label %if.else17.i
21+
br i1 %arg, label %if.end25.i, label %if.else17.i
2222

2323
if.else17.i:
2424
%shl24.i = shl i32 undef, undef

llvm/test/CodeGen/X86/fast-isel-stackcheck.ll

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@ entry:
1919
; CHECK-DAG: movq ___stack_chk_guard@GOTPCREL(%rip), %[[GUARD:r.x]]
2020
; CHECK-DAG: movq {{[0-9]+}}(%rsp), %[[CANARY:r.x]]
2121
; CHECK: subq %[[CANARY]], %[[GUARD]]
22-
define void @bar() #1 {
22+
define void @bar(i1 %arg) #1 {
2323
entry:
2424
%vt = alloca [2 x double], align 16
25-
br i1 undef, label %cleanup.4091, label %for.cond.3850
25+
br i1 %arg, label %cleanup.4091, label %for.cond.3850
2626

2727
unreachable:
2828
unreachable
2929

3030
for.cond.3850:
31-
br i1 undef, label %land.rhs.3853, label %land.end.3857
31+
br i1 %arg, label %land.rhs.3853, label %land.end.3857
3232

3333
land.rhs.3853:
3434
br label %land.end.3857

llvm/test/CodeGen/X86/fp-stack-O0-crash.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ if.end: ; preds = %if.then, %cond.fals
3131

3232
; PR10575
3333
; This produces a FP0 = IMPLICIT_DEF instruction.
34-
define void @__m_rankmerge_MOD_dindexmerge_() nounwind {
34+
define void @__m_rankmerge_MOD_dindexmerge_(i1 %arg) nounwind {
3535
entry:
3636
br label %"20"
3737

3838
"20": ; preds = %"23", %entry
3939
%0 = phi double [ undef, %entry ], [ %0, %"23" ]
4040
%1 = phi double [ 0.000000e+00, %entry ], [ %2, %"23" ]
41-
br i1 undef, label %"21", label %"23"
41+
br i1 %arg, label %"21", label %"23"
4242

4343
"21": ; preds = %"20"
4444
ret void

llvm/test/CodeGen/X86/fp-stack.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32-n8:16:32"
44
target triple = "i386-pc-linux-gnu"
55

6-
define void @foo() nounwind {
6+
define void @foo(i1 %arg) nounwind {
77
entry:
88
%tmp6 = load x86_fp80, ptr undef ; <x86_fp80> [#uses=2]
99
%tmp15 = load x86_fp80, ptr undef ; <x86_fp80> [#uses=2]
1010
%tmp24 = load x86_fp80, ptr undef ; <x86_fp80> [#uses=1]
11-
br i1 undef, label %return, label %bb.nph
11+
br i1 %arg, label %return, label %bb.nph
1212

1313
bb.nph: ; preds = %entry
1414
%cmp139 = fcmp ogt x86_fp80 %tmp15, %tmp6 ; <i1> [#uses=1]

llvm/test/CodeGen/X86/implicit-null-chk-reg-rewrite.mir

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# RUN: llc -mtriple=x86_64 -run-pass=implicit-null-checks %s -o - | FileCheck %s
22
--- |
33

4-
define i32 @reg-rewrite(ptr %x) {
4+
define i32 @reg-rewrite(ptr %x, i1 %arg) {
55
entry:
6-
br i1 undef, label %is_null, label %not_null, !make.implicit !0
6+
br i1 %arg, label %is_null, label %not_null, !make.implicit !0
77

88
is_null:
99
ret i32 42

llvm/test/CodeGen/X86/insert-positions.ll

+6-6
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
44

5-
define void @test0() nounwind {
5+
define void @test0(i1 %arg) nounwind {
66
if.end90.i.i:
77
br label %while.body.i.i221.i
88

99
while.body.i.i221.i: ; preds = %while.cond.backedge.i.i.i, %if.end90.i.i
10-
br i1 undef, label %if.then.i.i224.i, label %while.cond.backedge.i.i.i
10+
br i1 %arg, label %if.then.i.i224.i, label %while.cond.backedge.i.i.i
1111

1212
while.cond.backedge.i.i.i: ; preds = %for.end.i.i.i, %while.body.i.i221.i
1313
br label %while.body.i.i221.i
@@ -29,10 +29,10 @@ for.cond.i.i226.i: ; preds = %for.body.i.i.i, %if
2929
%0 = phi i64 [ %tmp154.i.i.i, %for.body.i.i.i ], [ 0, %if.then.i.i224.i ] ; <i64> [#uses=2]
3030
%tmp154.i.i.i = add i64 %0, 1 ; <i64> [#uses=2]
3131
%i.0.i.i.i = trunc i64 %0 to i32 ; <i32> [#uses=1]
32-
br i1 undef, label %land.rhs.i.i.i, label %for.end.i.i.i
32+
br i1 %arg, label %land.rhs.i.i.i, label %for.end.i.i.i
3333

3434
land.rhs.i.i.i: ; preds = %for.cond.i.i226.i
35-
br i1 undef, label %for.body.i.i.i, label %for.end.i.i.i
35+
br i1 %arg, label %for.body.i.i.i, label %for.end.i.i.i
3636

3737
for.body.i.i.i: ; preds = %land.rhs.i.i.i
3838
br label %for.cond.i.i226.i
@@ -45,7 +45,7 @@ for.end.i.i.i: ; preds = %land.rhs.i.i.i, %fo
4545
br label %while.cond.backedge.i.i.i
4646
}
4747

48-
define void @test1() nounwind {
48+
define void @test1(i1 %arg) nounwind {
4949
entry:
5050
%t = shl i32 undef, undef ; <i32> [#uses=1]
5151
%t9 = sub nsw i32 0, %t ; <i32> [#uses=1]
@@ -59,7 +59,7 @@ outer: ; preds = %bb18, %bb
5959
inner: ; preds = %bb16, %bb11
6060
%t17 = phi i32 [ %i13, %outer ], [ undef, %inner ] ; <i32> [#uses=1]
6161
store i32 %t17, ptr undef
62-
br i1 undef, label %bb18, label %inner
62+
br i1 %arg, label %bb18, label %inner
6363

6464
bb18: ; preds = %bb16
6565
%t19 = add i32 %i13, %t9 ; <i32> [#uses=1]

llvm/test/CodeGen/X86/legalize-sub-zero-2.ll

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
; RUN: llc < %s -mtriple=i386-apple-darwin
22

3-
define fastcc void @foo(i32 %type) nounwind optsize {
3+
define fastcc void @foo(i32 %type, i1 %arg) nounwind optsize {
44
entry:
55
switch i32 %type, label %bb26 [
66
i32 33634, label %bb11
@@ -15,19 +15,19 @@ bb26: ; preds = %entry
1515

1616
bb27: ; preds = %bb11, %entry
1717
%srcpb.0 = phi i32 [ 1, %bb11 ], [ 0, %entry ]
18-
br i1 undef, label %bb348, label %bb30.lr.ph
18+
br i1 %arg, label %bb348, label %bb30.lr.ph
1919

2020
bb30.lr.ph: ; preds = %bb27
2121
%.sum743 = shl i32 %srcpb.0, 1
2222
%0 = mul i32 %srcpb.0, -2
2323
%.sum745 = add i32 %.sum743, %0
24-
br i1 undef, label %bb70, label %bb71
24+
br i1 %arg, label %bb70, label %bb71
2525

2626
bb70: ; preds = %bb30.lr.ph
2727
unreachable
2828

2929
bb71: ; preds = %bb30.lr.ph
30-
br i1 undef, label %bb92, label %bb80
30+
br i1 %arg, label %bb92, label %bb80
3131

3232
bb80: ; preds = %bb71
3333
unreachable

llvm/test/CodeGen/X86/licm-symbol.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ target triple = "i386-apple-darwin8"
2121

2222
declare i32 @fprintf(ptr nocapture) nounwind
2323

24-
define void @gcov_exit() nounwind {
24+
define void @gcov_exit(i1 %arg) nounwind {
2525
entry:
2626
br label %bb151
2727

2828
bb151: ; preds = %bb59, %bb56, %bb14
29-
br i1 undef, label %bb56, label %bb59
29+
br i1 %arg, label %bb56, label %bb59
3030

3131
bb56: ; preds = %bb151
3232
%t0 = call i32 (ptr) @fprintf(ptr getelementptr inbounds ([0 x %struct.FILE], ptr @__sF, i32 0, i32 2)) nounwind

llvm/test/CodeGen/X86/liveness-local-regalloc.ll

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
declare fastcc i32 @func(ptr, i32, i32) nounwind ssp
1111

12-
define fastcc void @func2(ptr %arg, i32 %arg1) nounwind ssp {
12+
define fastcc void @func2(ptr %arg, i32 %arg1, i1 %arg2) nounwind ssp {
1313
bb:
1414
br label %.exit3
1515

@@ -20,7 +20,7 @@ bb:
2020
]
2121

2222
bb2: ; preds = %bb5, %bb3, %.exit3
23-
br i1 undef, label %bb3, label %bb5
23+
br i1 %arg2, label %bb3, label %bb5
2424

2525
bb3: ; preds = %bb2
2626
switch i32 undef, label %infloop [
@@ -41,7 +41,7 @@ bb5: ; preds = %bb2
4141

4242
.loopexit: ; preds = %bb5, %bb4, %bb3, %.exit3
4343
%.04 = phi i32 [ %tmp, %bb4 ], [ undef, %bb3 ], [ undef, %.exit3 ], [ undef, %bb5 ] ; <i32> [#uses=2]
44-
br i1 undef, label %bb8, label %bb6
44+
br i1 %arg2, label %bb8, label %bb6
4545

4646
bb6: ; preds = %.loopexit
4747
%tmp7 = tail call fastcc i32 @func(ptr %arg, i32 %.04, i32 undef) nounwind ssp ; <i32> [#uses=0]

llvm/test/CodeGen/X86/lsr-overflow.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ __ABContainsLabel.exit:
2626
ret i1 %cmp
2727
}
2828

29-
define void @func_37() noreturn nounwind readonly {
29+
define void @func_37(i1 %arg) noreturn nounwind readonly {
3030
entry:
3131
br label %for.body
3232

3333
for.body: ; preds = %for.inc8, %entry
3434
%indvar = phi i64 [ 0, %entry ], [ %indvar.next, %for.inc8 ]
3535
%sub.i = add i64 undef, %indvar
3636
%cmp.i = icmp eq i64 %sub.i, -9223372036854775808
37-
br i1 undef, label %for.inc8, label %for.cond4
37+
br i1 %arg, label %for.inc8, label %for.cond4
3838

3939
for.cond4: ; preds = %for.cond4, %for.body
4040
br label %for.cond4

llvm/test/CodeGen/XCore/2010-02-25-LSR-Crash.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ target triple = "xcore-xmos-elf"
77
%struct.object = type { ptr, ptr, ptr, %union.anon, %0, ptr }
88
%union.anon = type { ptr }
99

10-
define ptr @search_object(ptr %ob, ptr %pc) {
10+
define ptr @search_object(ptr %ob, ptr %pc, i1 %arg) {
1111
entry:
12-
br i1 undef, label %bb3.i15.i.i, label %bb2
12+
br i1 %arg, label %bb3.i15.i.i, label %bb2
1313

1414
bb3.i15.i.i: ; preds = %bb3.i15.i.i, %entry
1515
%indvar.i.i.i = phi i32 [ %indvar.next.i.i.i, %bb3.i15.i.i ], [ 0, %entry ] ; <i32> [#uses=2]

0 commit comments

Comments
 (0)