Fix code review issue

Author: xiaowei-guan

shell/platform/common/cpp/client_wrapper/include/flutter/texture_registrar.h

@@ -50,15 +50,15 @@ class GpuBufferTexture {
                                                        size_t height)>
       ObtainGpuBufferCallback;
 
-  typedef std::function<void(void* buffer)> DestructionGpuBufferCallback;
+  typedef std::function<void(void* buffer)> DestructGpuBufferCallback;
 
-  // Creates a gpu buffer texture that uses the provided |copy_buffer_cb| to
+  // Creates a gpu buffer texture that uses the provided |obtain_buffer_cb| to
   // retrieve the buffer.
   // As the callback is usually invoked from the render thread, the callee must
   // take care of proper synchronization. It also needs to be ensured that the
   // returned buffer isn't released prior to unregistering this texture.
   GpuBufferTexture(ObtainGpuBufferCallback obtain_buffer_callback,
-                   DestructionGpuBufferCallback destruction_callback)
+                   DestructGpuBufferCallback destruction_callback)
       : obtain_gpu_buffer_callback_(obtain_buffer_callback),
         destruct_gpu_buffer_callback_(destruction_callback),
         buffer_(nullptr) {}
@@ -79,7 +79,7 @@ class GpuBufferTexture {
 
  private:
   const ObtainGpuBufferCallback obtain_gpu_buffer_callback_;
-  const DestructionGpuBufferCallback destruct_gpu_buffer_callback_;
+  const DestructGpuBufferCallback destruct_gpu_buffer_callback_;
   void* buffer_;
 };
 

shell/platform/common/cpp/public/flutter_texture_registrar.h

@@ -81,7 +81,7 @@ typedef struct {
 typedef struct {
   // The callback used by the engine to obtain the GPU buffer object.
   FlutterDesktopGpuBufferTextureCallback callback;
-  // The callback used by the engine to destruct GPU buffer object.
+  // The callback used by the engine to destruct the GPU buffer object.
   FlutterDesktopGpuBufferDestructionCallback destruction_callback;
   // Opaque data that will get passed to the provided |callback|.
   void* user_data;

shell/platform/tizen/external_texture.h

@@ -12,31 +12,23 @@
 
 #ifdef TIZEN_RENDERER_EVAS_GL
 #undef EFL_BETA_API_SUPPORT
-#include <Ecore.h>
-#include <Elementary.h>
-#include <Evas_GL_GLES3_Helpers.h>
-extern Evas_GL* g_evas_gl;
-EVAS_GL_GLOBAL_GLES3_DECLARE();
+#include <Evas_GL.h>
 #else
-#include <EGL/egl.h>
-#include <EGL/eglext.h>
 #include <GLES2/gl2.h>
-#include <GLES2/gl2ext.h>
-#include <GLES3/gl32.h>
 #endif
 
 struct ExternalTextureGLState {
   GLuint gl_texture;
 };
 
-static std::atomic_long kNextTextureId = {1};
+static std::atomic_long next_texture_id = {1};
 
 // An adaptation class of flutter engine and external texture interface.
 class ExternalTexture : public std::enable_shared_from_this<ExternalTexture> {
  public:
   ExternalTexture()
       : state_(std::make_unique<ExternalTextureGLState>()),
-        texture_id_(kNextTextureId++) {}
+        texture_id_(next_texture_id++) {}
   virtual ~ExternalTexture() = default;
 
   /**

shell/platform/tizen/external_texture_pixel_gl.cc

@@ -6,15 +6,12 @@
 
 #ifdef TIZEN_RENDERER_EVAS_GL
 #undef EFL_BETA_API_SUPPORT
-#include <Ecore.h>
-#include <Elementary.h>
 #include <Evas_GL_GLES3_Helpers.h>
 extern Evas_GL* g_evas_gl;
 EVAS_GL_GLOBAL_GLES3_DECLARE();
 #else
 #include <EGL/egl.h>
 #include <EGL/eglext.h>
-#include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <GLES3/gl32.h>
 #endif

shell/platform/tizen/external_texture_surface_gl.cc

@@ -8,15 +8,12 @@
 
 #ifdef TIZEN_RENDERER_EVAS_GL
 #undef EFL_BETA_API_SUPPORT
-#include <Ecore.h>
-#include <Elementary.h>
 #include <Evas_GL_GLES3_Helpers.h>
 extern Evas_GL* g_evas_gl;
 EVAS_GL_GLOBAL_GLES3_DECLARE();
 #else
 #include <EGL/egl.h>
 #include <EGL/eglext.h>
-#include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <GLES3/gl32.h>
 #endif