Skip to content

Commit da9cfb3

Browse files
bderodnfield
authored andcommitted
Separate FilterInput variants into their own TUs (#152)
1 parent 5ec32d7 commit da9cfb3

18 files changed

+352
-324
lines changed

impeller/entity/BUILD.gn

+10-4
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,20 @@ impeller_component("entity") {
3939
"contents/contents.h",
4040
"contents/filters/blend_filter_contents.cc",
4141
"contents/filters/blend_filter_contents.h",
42+
"contents/filters/border_mask_blur_filter_contents.cc",
43+
"contents/filters/border_mask_blur_filter_contents.h",
4244
"contents/filters/filter_contents.cc",
4345
"contents/filters/filter_contents.h",
44-
"contents/filters/filter_input.cc",
45-
"contents/filters/filter_input.h",
4646
"contents/filters/gaussian_blur_filter_contents.cc",
4747
"contents/filters/gaussian_blur_filter_contents.h",
48-
"contents/filters/border_mask_blur_filter_contents.cc",
49-
"contents/filters/border_mask_blur_filter_contents.h",
48+
"contents/filters/inputs/contents_filter_input.cc",
49+
"contents/filters/inputs/contents_filter_input.h",
50+
"contents/filters/inputs/filter_contents_filter_input.cc",
51+
"contents/filters/inputs/filter_contents_filter_input.h",
52+
"contents/filters/inputs/filter_input.cc",
53+
"contents/filters/inputs/filter_input.h",
54+
"contents/filters/inputs/texture_filter_input.cc",
55+
"contents/filters/inputs/texture_filter_input.h",
5056
"contents/linear_gradient_contents.cc",
5157
"contents/linear_gradient_contents.h",
5258
"contents/snapshot.cc",

impeller/entity/contents/filters/blend_filter_contents.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#include "impeller/entity/contents/filters/blend_filter_contents.h"
66

77
#include "impeller/entity/contents/content_context.h"
8-
#include "impeller/entity/contents/filters/filter_input.h"
8+
#include "impeller/entity/contents/filters/inputs/filter_input.h"
99
#include "impeller/renderer/render_pass.h"
1010
#include "impeller/renderer/sampler_library.h"
1111

impeller/entity/contents/filters/blend_filter_contents.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#pragma once
66

77
#include "impeller/entity/contents/filters/filter_contents.h"
8-
#include "impeller/entity/contents/filters/filter_input.h"
8+
#include "impeller/entity/contents/filters/inputs/filter_input.h"
99

1010
namespace impeller {
1111

impeller/entity/contents/filters/border_mask_blur_filter_contents.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <memory>
88
#include <optional>
99
#include "impeller/entity/contents/filters/filter_contents.h"
10-
#include "impeller/entity/contents/filters/filter_input.h"
10+
#include "impeller/entity/contents/filters/inputs/filter_input.h"
1111

1212
namespace impeller {
1313

impeller/entity/contents/filters/filter_contents.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
#include "impeller/entity/contents/content_context.h"
1717
#include "impeller/entity/contents/filters/blend_filter_contents.h"
1818
#include "impeller/entity/contents/filters/border_mask_blur_filter_contents.h"
19-
#include "impeller/entity/contents/filters/filter_input.h"
19+
#include "impeller/entity/contents/filters/inputs/filter_input.h"
2020
#include "impeller/entity/contents/filters/gaussian_blur_filter_contents.h"
2121
#include "impeller/entity/contents/texture_contents.h"
2222
#include "impeller/entity/entity.h"

impeller/entity/contents/filters/filter_contents.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <variant>
99
#include <vector>
1010

11-
#include "impeller/entity/contents/filters/filter_input.h"
11+
#include "impeller/entity/contents/filters/inputs/filter_input.h"
1212
#include "impeller/entity/entity.h"
1313
#include "impeller/renderer/formats.h"
1414

@@ -145,8 +145,6 @@ class FilterContents : public Contents {
145145
FilterInput::Vector inputs_;
146146

147147
FML_DISALLOW_COPY_AND_ASSIGN(FilterContents);
148-
149-
friend FilterContentsFilterInput;
150148
};
151149

152150
} // namespace impeller

impeller/entity/contents/filters/filter_input.cc

-158
This file was deleted.

impeller/entity/contents/filters/filter_input.h

-153
This file was deleted.

0 commit comments

Comments
 (0)