Skip to content

Commit 2156945

Browse files
committed
[webview_flutter] Apply review comment
Signed-off-by: MuHong Byun <[email protected]>
1 parent 31d6176 commit 2156945

File tree

5 files changed

+7
-9
lines changed

5 files changed

+7
-9
lines changed

packages/webview_flutter/tizen/src/webview.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <Ecore_Input_Evas.h>
99
#include <flutter_platform_view.h>
1010
#include <flutter_texture_registrar.h>
11-
#include <texture_registrar.h>
11+
#include <flutter/texture_registrar.h>
1212

1313
#include <map>
1414
#include <memory>
@@ -172,7 +172,7 @@ WebView::WebView(flutter::PluginRegistrar* registrar, int viewId,
172172
gpu_buffer_(nullptr) {
173173
texture_variant_ = new flutter::TextureVariant(flutter::GpuBufferTexture(
174174
[this](size_t width, size_t height) -> const FlutterDesktopGpuBuffer* {
175-
return this->CopyGpuBuffer(width, height);
175+
return this->ObtainGpuBuffer(width, height);
176176
},
177177
[this](void* buffer) -> void { this->DestructBuffer(buffer); }));
178178
SetTextureId(texture_registrar_->RegisterTexture(texture_variant_));
@@ -922,7 +922,7 @@ void WebView::HandleCookieMethodCall(
922922
}
923923
}
924924

925-
FlutterDesktopGpuBuffer* WebView::CopyGpuBuffer(size_t width, size_t height) {
925+
FlutterDesktopGpuBuffer* WebView::ObtainGpuBuffer(size_t width, size_t height) {
926926
if (!candidate_surface_) {
927927
return nullptr;
928928
}

packages/webview_flutter/tizen/src/webview.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class WebView : public PlatformView {
4848
void HidePanel();
4949
void ShowPanel();
5050

51-
FlutterDesktopGpuBuffer* CopyGpuBuffer(size_t width, size_t height);
51+
FlutterDesktopGpuBuffer* ObtainGpuBuffer(size_t width, size_t height);
5252
void DestructBuffer(void* buffer);
5353

5454
private:

packages/webview_flutter/tizen/src/webview_factory.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include <flutter/standard_message_codec.h>
1111
#include <flutter/standard_method_codec.h>
1212
#include <flutter_platform_view.h>
13-
#include <flutter_tizen_texture_registrar.h>
1413

1514
#include <map>
1615
#include <memory>
@@ -23,7 +22,7 @@
2322

2423
WebViewFactory::WebViewFactory(flutter::PluginRegistrar* registrar,
2524
flutter::TextureRegistrar* textureRegistrar)
26-
: PlatformViewFactory(registrar), textureRegistrar_(textureRegistrar) {
25+
: PlatformViewFactory(registrar), texture_registrar_(textureRegistrar) {
2726
char* path = app_get_data_path();
2827
if (!path || strlen(path) == 0) {
2928
path = "/tmp/";
@@ -51,7 +50,7 @@ PlatformView* WebViewFactory::Create(int viewId, double width, double height,
5150
}
5251

5352
try {
54-
return new WebView(GetPluginRegistrar(), viewId, textureRegistrar_, width,
53+
return new WebView(GetPluginRegistrar(), viewId, texture_registrar_, width,
5554
height, params);
5655
} catch (const std::invalid_argument& ex) {
5756
LOG_ERROR("[Exception] %s\n", ex.what());

packages/webview_flutter/tizen/src/webview_factory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class WebViewFactory : public PlatformViewFactory {
1616
const std::vector<uint8_t>& createParams) override;
1717

1818
private:
19-
flutter::TextureRegistrar* textureRegistrar_;
19+
flutter::TextureRegistrar* texture_registrar_;
2020
};
2121

2222
#endif // FLUTTER_PLUGIN_WEBVIEW_FLUTTER_TIZEN_WEVIEW_FACTORY_H_

packages/webview_flutter/tizen/src/webview_flutter_tizen_plugin.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <flutter/standard_message_codec.h>
1010
#include <flutter/standard_method_codec.h>
1111
#include <flutter_platform_view.h>
12-
#include <flutter_tizen_texture_registrar.h>
1312

1413
#include <map>
1514
#include <memory>

0 commit comments

Comments
 (0)