Skip to content

Commit fffd251

Browse files
committed
Remove some ignore directives
- Sort entries in labeler alphabetically. - Add missing tizen_notification label.
1 parent 44534bf commit fffd251

File tree

4 files changed

+32
-26
lines changed

4 files changed

+32
-26
lines changed

.github/labeler.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
- packages/path_provider/**/*
3030
'p: permission_handler':
3131
- packages/permission_handler/**/*
32-
'p: shared_preferences':
33-
- packages/shared_preferences/**/*
3432
'p: sensors_plus':
3533
- packages/sensors_plus/**/*
36-
'p: sqflite':
37-
- packages/sqflite/**/*
3834
'p: share_plus':
3935
- packages/share_plus/**/*
36+
'p: shared_preferences':
37+
- packages/shared_preferences/**/*
38+
'p: sqflite':
39+
- packages/sqflite/**/*
4040
'p: tizen_app_control':
4141
- packages/tizen_app_control/**/*
4242
'p: tizen_app_manager':
@@ -45,6 +45,8 @@
4545
- packages/tizen_audio_manager/**/*
4646
'p: tizen_log':
4747
- packages/tizen_log/**/*
48+
'p: tizen_notification':
49+
- packages/tizen_notification/**/*
4850
'p: tizen_package_manager':
4951
- packages/tizen_package_manager/**/*
5052
'p: url_launcher':

packages/sqflite/example/lib/manual_test_page.dart

+16-15
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
import 'dart:async';
22

3-
import 'package:flutter/material.dart' hide MenuItem;
3+
import 'package:flutter/material.dart';
44
import 'package:sqflite/sqflite.dart';
55
// ignore: implementation_imports
66
import 'package:sqflite/src/factory_mixin.dart' as impl;
77
import 'package:sqflite/utils/utils.dart';
8-
import 'package:sqflite_tizen_example/model/item.dart';
98
import 'package:sqflite_tizen_example/src/item_widget.dart';
109
import 'package:sqflite_tizen_example/utils.dart';
1110

11+
import 'model/item.dart';
12+
1213
// ignore_for_file: avoid_print
1314

1415
/// Manual test page.
@@ -44,7 +45,7 @@ class _ManualTestPageState extends State<ManualTestPage> {
4445
await database?.setVersion(version + 1);
4546
}
4647

47-
late List<MenuItem> items;
48+
late List<SqfMenuItem> items;
4849
late List<ItemWidget> itemWidgets;
4950

5051
Future<bool> pop() async {
@@ -54,53 +55,53 @@ class _ManualTestPageState extends State<ManualTestPage> {
5455
@override
5556
void didChangeDependencies() {
5657
super.didChangeDependencies();
57-
items = <MenuItem>[
58-
MenuItem('openDatabase', () async {
58+
items = <SqfMenuItem>[
59+
SqfMenuItem('openDatabase', () async {
5960
await _openDatabase();
6061
}, summary: 'Open the database'),
61-
MenuItem('BEGIN EXCLUSIVE', () async {
62+
SqfMenuItem('BEGIN EXCLUSIVE', () async {
6263
final db = await _openDatabase();
6364
await db.execute('BEGIN EXCLUSIVE');
6465
},
6566
summary:
6667
'Execute than exit or hot-restart the application. Open the database if needed'),
67-
MenuItem('close', () async {
68+
SqfMenuItem('close', () async {
6869
await _closeDatabase();
6970
},
7071
summary:
7172
'Execute after starting then exit the app using the back button on Android and restart from the launcher.'),
72-
MenuItem('delete', () async {
73+
SqfMenuItem('delete', () async {
7374
await _deleteDatabase();
7475
},
7576
summary:
7677
'Try open (then optionally) delete, exit or hot-restart then delete then open'),
77-
MenuItem('log level: none', () async {
78+
SqfMenuItem('log level: none', () async {
7879
// ignore: deprecated_member_use
7980
await Sqflite.devSetOptions(
8081
// ignore: deprecated_member_use
8182
SqfliteOptions(logLevel: sqfliteLogLevelNone));
8283
}, summary: 'No logs'),
83-
MenuItem('log level: sql', () async {
84+
SqfMenuItem('log level: sql', () async {
8485
// ignore: deprecated_member_use
8586
await Sqflite.devSetOptions(
8687
// ignore: deprecated_member_use
8788
SqfliteOptions(logLevel: sqfliteLogLevelSql));
8889
}, summary: 'Log sql command and basic database operation'),
89-
MenuItem('log level: verbose', () async {
90+
SqfMenuItem('log level: verbose', () async {
9091
// ignore: deprecated_member_use
9192
await Sqflite.devSetOptions(
9293
// ignore: deprecated_member_use
9394
SqfliteOptions(logLevel: sqfliteLogLevelVerbose));
9495
}, summary: 'Verbose logs, for debugging'),
95-
MenuItem('Get info', () async {
96+
SqfMenuItem('Get info', () async {
9697
final factory = databaseFactory as impl.SqfliteDatabaseFactoryMixin;
9798
final info = await factory.getDebugInfo();
9899
print(info.toString());
99100
}, summary: 'Implementation info (dev only)'),
100-
MenuItem('Increment version', () async {
101+
SqfMenuItem('Increment version', () async {
101102
await _incrementVersion();
102103
}, summary: 'Implementation info (dev only)'),
103-
MenuItem('Multiple db', () async {
104+
SqfMenuItem('Multiple db', () async {
104105
await Navigator.of(context).push(MaterialPageRoute(builder: (_) {
105106
return const MultipleDbTestPage();
106107
}));
@@ -115,7 +116,7 @@ class _ManualTestPageState extends State<ManualTestPage> {
115116
item,
116117
(item) async {
117118
final stopwatch = Stopwatch()..start();
118-
final future = (item as MenuItem).run();
119+
final future = (item as SqfMenuItem).run();
119120
setState(() {});
120121
await future;
121122
// always add a small delay

packages/sqflite/example/lib/model/item.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ class Item {
2828
}
2929

3030
/// Menu item implementation.
31-
class MenuItem extends Item {
31+
class SqfMenuItem extends Item {
3232
/// Menu item implementation.
33-
MenuItem(String name, this.body, {this.summary}) : super(name) {
33+
SqfMenuItem(String name, this.body, {this.summary}) : super(name) {
3434
state = ItemState.none;
3535
}
3636

packages/webview_flutter/lib/src/platform_view_tizen.dart

+8-5
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class TizenView extends StatefulWidget {
2424
this.gestureRecognizers,
2525
this.creationParams,
2626
this.creationParamsCodec,
27+
this.clipBehavior = Clip.hardEdge,
2728
}) : assert(viewType != null),
2829
assert(hitTestBehavior != null),
2930
assert(creationParams == null || creationParamsCodec != null),
@@ -36,6 +37,7 @@ class TizenView extends StatefulWidget {
3637
final Set<Factory<OneSequenceGestureRecognizer>>? gestureRecognizers;
3738
final dynamic creationParams;
3839
final MessageCodec<dynamic>? creationParamsCodec;
40+
final Clip clipBehavior;
3941

4042
@override
4143
State<TizenView> createState() => _TizenWebViewState();
@@ -57,10 +59,11 @@ class _TizenWebViewState extends State<TizenView> {
5759
focusNode: _focusNode,
5860
onFocusChange: _onFocusChange,
5961
child: _TizenPlatformTextureView(
60-
controller: _controller,
61-
hitTestBehavior: widget.hitTestBehavior,
62-
gestureRecognizers:
63-
widget.gestureRecognizers ?? _emptyRecognizersSet),
62+
controller: _controller,
63+
hitTestBehavior: widget.hitTestBehavior,
64+
gestureRecognizers: widget.gestureRecognizers ?? _emptyRecognizersSet,
65+
clipBehavior: widget.clipBehavior,
66+
),
6467
);
6568
}
6669

@@ -591,7 +594,6 @@ class _TizenPlatformTextureView extends LeafRenderObjectWidget {
591594
required this.controller,
592595
required this.hitTestBehavior,
593596
required this.gestureRecognizers,
594-
// ignore: unused_element
595597
this.clipBehavior = Clip.hardEdge,
596598
}) : assert(controller != null),
597599
assert(hitTestBehavior != null),
@@ -616,5 +618,6 @@ class _TizenPlatformTextureView extends LeafRenderObjectWidget {
616618
renderObject.viewController = controller;
617619
renderObject.hitTestBehavior = hitTestBehavior;
618620
renderObject.updateGestureRecognizers(gestureRecognizers);
621+
renderObject.clipBehavior = clipBehavior;
619622
}
620623
}

0 commit comments

Comments
 (0)