Skip to content

Commit 8935f28

Browse files
authored
[deep link] Add more explanation for cross checking. (#8020)
* wording 1 * Update validation_details_view.dart * wording
1 parent 0fd50b0 commit 8935f28

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

packages/devtools_app/lib/src/screens/deep_link_validation/validation_details_view.dart

+19-2
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,7 @@ class _CrossCheckTable extends StatelessWidget {
578578
final missingIos = hasIosAasaFile && !linkData.os.contains(PlatformOS.ios);
579579
final missingAndroid =
580580
hasAndroidAssetLinksFile && !linkData.os.contains(PlatformOS.android);
581+
if (!missingIos && !missingAndroid) return const SizedBox.shrink();
581582

582583
final theme = Theme.of(context);
583584
final domainMissing = Text(
@@ -602,14 +603,30 @@ class _CrossCheckTable extends StatelessWidget {
602603
os: PlatformOS.android,
603604
checkName: 'Manifest file',
604605
status: domainMissing,
605-
children: const <Widget>[],
606+
children: const <Widget>[
607+
Padding(
608+
padding: EdgeInsets.symmetric(horizontal: defaultSpacing),
609+
child: Text(
610+
'This domain has an Asset link json file but it\'s missing in the android manifest file. '
611+
'If you want to set up deep linking for Android, you need to add this domain '
612+
'to your AndroidManifest.xml file.'),
613+
),
614+
],
606615
),
607616
if (missingIos)
608617
_CheckExpansionTile(
609618
os: PlatformOS.ios,
610619
checkName: 'Settings',
611620
status: domainMissing,
612-
children: const <Widget>[],
621+
children: const <Widget>[
622+
Padding(
623+
padding: EdgeInsets.symmetric(horizontal: defaultSpacing),
624+
child: Text(
625+
'This domain has an AASA file but it\'s missing in local settings. '
626+
'If you want to set up deep linking for iOS, you need to add this domain '
627+
'to your info.Plist file.'),
628+
),
629+
],
613630
),
614631
],
615632
);

0 commit comments

Comments
 (0)