Skip to content

DevTools with CanvasKit does not work on Chrome 86 #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grouma opened this issue Aug 19, 2020 · 9 comments · Fixed by flutter/engine#21061
Closed

DevTools with CanvasKit does not work on Chrome 86 #2290

grouma opened this issue Aug 19, 2020 · 9 comments · Fixed by flutter/engine#21061

Comments

@grouma
Copy link
Member

grouma commented Aug 19, 2020

Seeing the following unminified error:

Uncaught TypeError: FinalizationRegistry: cleanup must be callable
    at new FinalizationRegistry (<anonymous>)
    at canvaskit_api.dart:1597
    at Object.holder.<computed> [as $get$skObjectFinalizationRegistry] (main.dart.js:117)
    at CkPaint.ManagedSkiaObject$0 (skia_object_cache.dart:133)
    at Object.CkPaint$ (painting.dart:13)
    at painting.dart:907
    at _wrapJsFunctionForAsync_closure.$protected (async_patch.dart:315)
    at _wrapJsFunctionForAsync_closure.call$2 (async_patch.dart:340)
    at Object._asyncStartSync (async_patch.dart:245)
    at DefaultShaderWarmUp.warmUpOnCanvas$body$DefaultShaderWarmUp (shader_warm_up.dart:129)
@jacob314
Copy link
Contributor

Has this been fixed with tip of trunk Flutter? If not then we need to file a bug there.

@ferhatb
Copy link

ferhatb commented Aug 26, 2020

/cc @hterkelsen @yjbanov

@grouma
Copy link
Member Author

grouma commented Aug 26, 2020

It's hard to verify if this is still broken as we have another blocking issue on Chrome Canary: dart-lang/webdev#1087

@yjbanov
Copy link

yjbanov commented Sep 1, 2020

I'm unable to reproduce in Chrome 86.0.4239.0. Can you please provide your chrome://version info?

@jpohhhh
Copy link

jpohhhh commented Sep 3, 2020

fwiw I'm on 86.0.4240.11 and seeing this

@harryterkelsen
Copy link

I filed an issue with dart2js to fix this in the compiler: dart-lang/sdk#43373

In the meantime I am landing a fix to the engine.

@yjbanov
Copy link

yjbanov commented Sep 18, 2020

I think we can close this now?

@grouma
Copy link
Member Author

grouma commented Oct 9, 2020

I'm seeing this with the latest DevTools version pulled into package:dwds / package:webdev. (version 0.9.3+4)

@hterkelsen did your fix land?

@mariamhas
Copy link

This shouldn't be an issue anymore @grouma can you confirm if you still see this issue?

@grouma grouma closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants