Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 016ec95

Browse files
authored
Migrate const_finder_test to use package:test (#55132)
... instead of some home-grown framework. This is the last test in the engine that uses custom command line arguments to start. As of this PR, `dart test` including full debugging in an IDE works across all Dart tooling code. I tried to make this idiomatic as much as possible without changing the logic.
1 parent dcfecdb commit 016ec95

File tree

3 files changed

+402
-468
lines changed

3 files changed

+402
-468
lines changed

testing/run_tests.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -988,14 +988,7 @@ def build_dart_host_test_list(build_dir):
988988
),
989989
(os.path.join('flutter', 'tools', 'build_bucket_golden_scraper'), []),
990990
(os.path.join('flutter', 'tools', 'clang_tidy'), []),
991-
(
992-
os.path.join('flutter', 'tools', 'const_finder'),
993-
[
994-
os.path.join(build_dir, 'gen', 'frontend_server_aot.dart.snapshot'),
995-
os.path.join(build_dir, 'flutter_patched_sdk'),
996-
os.path.join(build_dir, 'dart-sdk', 'lib', 'libraries.json'),
997-
],
998-
),
991+
(os.path.join('flutter', 'tools', 'const_finder'), []),
999992
(os.path.join('flutter', 'tools', 'dir_contents_diff'), []),
1000993
(os.path.join('flutter', 'tools', 'engine_tool'), []),
1001994
(os.path.join('flutter', 'tools', 'githooks'), []),

tools/const_finder/pubspec.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,6 @@ dependencies:
1818

1919
dev_dependencies:
2020
collection: any
21+
engine_repo_tools: any
2122
path: any
23+
test: any

0 commit comments

Comments
 (0)