Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 1394832

Browse files
authored
[impeller] added moltenvk notice (#41317)
fixes flutter/flutter#125076 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 722ecb1 commit 1394832

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

impeller/playground/backend/vulkan/playground_impl_vk.cc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,15 @@ PlaygroundImplVK::PlaygroundImplVK(PlaygroundSwitches switches)
5353
concurrent_loop_(fml::ConcurrentMessageLoop::Create()),
5454
handle_(nullptr, &DestroyWindowHandle) {
5555
if (!::glfwVulkanSupported()) {
56+
#ifdef TARGET_OS_MAC
57+
VALIDATION_LOG << "Attempted to initialize a Vulkan playground on macOS "
58+
"where Vulkan cannot be found. It can be installed via "
59+
"MoltenVK and make sure to install it globally so "
60+
"dlopen can find it.";
61+
#else
5662
VALIDATION_LOG << "Attempted to initialize a Vulkan playground on a system "
5763
"that does not support Vulkan.";
64+
#endif
5865
return;
5966
}
6067

0 commit comments

Comments
 (0)