Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 156eba0

Browse files
committed
[docs] Add missing steps to Testing Presubmit Engine PRs
Most framework tests perform a `flutter precache` or rely on the web SDK in some form. The Web SDK is not build in presubmit by default. As such, developers will need to manually comment out the `runIf` conditional block that prevents the web SDK from being built during presubmit, then later hope they uncomment it before landing their patch.
1 parent cc732b4 commit 156eba0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ This documentation describes how to run flutter/flutter presubmit checks on flut
44

55
# Overview
66

7+
1. Edit `.ci.yaml`, comment out the `runIf:` block in `linux_web_engine` to ensure Flutter Web artifacts build (otherwise most framework tests will fail during precache).
78
1. Wait for all presubmit checks on your flutter/engine PR to be green.
8-
2. Determine the commit hash for your flutter/engine PR.
9-
3. Create and upload a flutter/flutter PR, (OR run tests locally).
10-
4. Wait for flutter/flutter presubmits/tests to run ☕.
11-
12-
Step (1) is the usual flutter/engine workflow.
9+
1. Determine the commit hash for your flutter/engine PR.
10+
1. Create and upload a flutter/flutter PR, (OR run tests locally).
11+
1. Wait for flutter/flutter presubmits/tests to run ☕.
12+
1. Edit `.ci.yaml` to uncomment the `runIf` block you commented out above.
1313

1414
# 2. The commit hash
1515

0 commit comments

Comments
 (0)