Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 256dc78

Browse files
authored
Reland "[web] Avoid returning int from js interop classes." (#37627)
1 parent c05e7ff commit 256dc78

30 files changed

+288
-324
lines changed

lib/web_ui/lib/src/engine/assets.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class AssetManager {
8484
printWarning('Asset manifest does not exist at `$url` – ignoring.');
8585
return Uint8List.fromList(utf8.encode('{}')).buffer.asByteData();
8686
}
87-
throw AssetManagerException(url, request.status!);
87+
throw AssetManagerException(url, request.status!.toInt());
8888
}
8989

9090
final String? constructorName = target == null ? 'null' :

lib/web_ui/lib/src/engine/browser_detection.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ OperatingSystem detectOperatingSystem({
142142
// iDevices requesting a "desktop site" spoof their UA so it looks like a Mac.
143143
// This checks if we're in a touch device, or on a real mac.
144144
final int maxTouchPoints =
145-
overrideMaxTouchPoints ?? domWindow.navigator.maxTouchPoints ?? 0;
145+
overrideMaxTouchPoints ?? domWindow.navigator.maxTouchPoints?.toInt() ?? 0;
146146
if (maxTouchPoints > 2) {
147147
return OperatingSystem.iOs;
148148
}

lib/web_ui/lib/src/engine/canvaskit/canvas.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class CkCanvas {
3737

3838
final SkCanvas skCanvas;
3939

40-
int? get saveCount => skCanvas.getSaveCount();
40+
int? get saveCount => skCanvas.getSaveCount().toInt();
4141

4242
void clear(ui.Color color) {
4343
skCanvas.clear(toSharedSkColor1(color));
@@ -274,7 +274,7 @@ class CkCanvas {
274274
}
275275

276276
int save() {
277-
return skCanvas.save();
277+
return skCanvas.save().toInt();
278278
}
279279

280280
void saveLayer(ui.Rect bounds, CkPaint? paint) {

0 commit comments

Comments
 (0)