Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 31fd415

Browse files
authored
[Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (#53720)
Doesn't rename the field to maintain API compatibility. But adds a bug annotation. Fixes flutter/flutter#148637
1 parent 1af5cef commit 31fd415

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

shell/platform/embedder/embedder.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,14 @@ typedef struct {
387387
} FlutterOpenGLTexture;
388388

389389
typedef struct {
390-
/// The target of the color attachment of the frame-buffer. For example,
391-
/// GL_TEXTURE_2D or GL_RENDERBUFFER. In case of ambiguity when dealing with
392-
/// Window bound frame-buffers, 0 may be used.
390+
/// The format of the color attachment of the frame-buffer. For example,
391+
/// GL_RGBA8.
392+
///
393+
/// In case of ambiguity when dealing with Window bound frame-buffers, 0 may
394+
/// be used.
395+
///
396+
/// @bug This field is incorrectly named as "target" when it actually
397+
/// refers to a format.
393398
uint32_t target;
394399

395400
/// The name of the framebuffer.

0 commit comments

Comments
 (0)