[Impeller] Remove validation log when the pipeline library is collected before pipeline is setup. (#38306)

chinmaygarde · web-flow · commit 3b2302c8dd1b · 2022-12-15T02:23:23.000Z
This is a benign condition but the validation logs could be fatal since 8744c93c4d5. Don't crash in these situations.
diff --git a/impeller/renderer/backend/metal/pipeline_library_mtl.mm b/impeller/renderer/backend/metal/pipeline_library_mtl.mm
@@ -119,8 +119,6 @@
 
         auto strong_this = weak_this.lock();
         if (!strong_this) {
-          VALIDATION_LOG << "Library was collected before a pending pipeline "
-                            "creation could finish.";
           promise->set_value(nullptr);
           return;
         }

Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,6 @@`
`119`	`119`
`120`	`120`	`auto strong_this = weak_this.lock();`
`121`	`121`	`if (!strong_this) {`
`122`		`- VALIDATION_LOG << "Library was collected before a pending pipeline "`
`123`		`- "creation could finish.";`
`124`	`122`	`promise->set_value(nullptr);`
`125`	`123`	`return;`
`126`	`124`	`}`