Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 3ee25e9

Browse files
chinmaygardeSkia Commit-Bot
authored and
Skia Commit-Bot
committed
Don't link against MetalKit when building the base Skia library.
MetalKit was introduced in iOS 9 and contains utilities for building applications with Metal. None of these utilities actually seem to be in use. However, linking against MetalKit means Flutter cannot deploy a unified binary to iOS 8. This patch removes the unused dependency and unblocks Flutter. Fixes flutter/flutter#64017 Change-Id: I2cf54a1c95b4c3cda96300861598f2cb23f583d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314539 Reviewed-by: Jim Van Verth <[email protected]> Reviewed-by: Xiao Yu <[email protected]> Commit-Queue: Jim Van Verth <[email protected]>
1 parent 4985db4 commit 3ee25e9

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

BUILD.gn

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -832,7 +832,6 @@ optional("gpu") {
832832
public_defines += [ "SK_METAL" ]
833833
sources += skia_metal_sources
834834
frameworks += [ "Metal.framework" ]
835-
frameworks += [ "MetalKit.framework" ]
836835
frameworks += [ "Foundation.framework" ]
837836
cflags_objcc += [ "-fobjc-arc" ]
838837
}
@@ -1798,9 +1797,11 @@ if (skia_enable_tools) {
17981797
import("gn/tests.gni")
17991798
test_lib("tests") {
18001799
sources = tests_sources + pathops_tests_sources
1800+
frameworks = []
18011801
if (skia_use_metal) {
18021802
sources += metal_tests_sources
18031803
cflags_objcc = [ "-fobjc-arc" ]
1804+
frameworks += [ "MetalKit.framework" ]
18041805
}
18051806
if (skia_use_gl) {
18061807
sources += gl_tests_sources

0 commit comments

Comments
 (0)