Disable a flaky Scenarios test (#21075)

cbracken · web-flow · commit 55d447a1c3e1 · 2020-09-10T13:21:17.000-07:00
This disables the macOS Scenarios app test testFlutterViewControllerDetachingSendsApplicationLifecycle until a fix for the flakiness is found. Related issue: flutter/flutter#61620
diff --git a/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m b/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m
@@ -227,7 +227,9 @@ - (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle {
   [engine setViewController:nil];
 }
 
-- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {
+// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
+// has been identified. https://github.com/flutter/flutter/issues/61620
+- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {
   XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
 
   // Let the engine finish booting (at the end of which the channels are properly set-up) before

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,9 @@ - (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle {`
`227`	`227`	`[engine setViewController:nil];`
`228`	`228`	`}`
`229`	`229`
`230`		`-- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {`
	`230`	`+// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness`
	`231`	`+// has been identified. https://github.com/flutter/flutter/issues/61620`
	`232`	`+- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {`
`231`	`233`	`XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];`
`232`	`234`
`233`	`235`	`// Let the engine finish booting (at the end of which the channels are properly set-up) before`