Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5ba6534

Browse files
erock2112Skia Commit-Bot
authored and
Skia Commit-Bot
committed
Change some instances of whitelist/blacklist
Bug: chromium:1101491 Bug: b/161896447 Change-Id: I7e3bf4ed63b2170fb08fe1ec8e7d934e7fcdca7c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306644 Reviewed-by: Leon Scroggins <[email protected]> Commit-Queue: Eric Boren <[email protected]>
1 parent 2d37958 commit 5ba6534

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

gn/gn_to_bp_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ def GrabDependentValues(js, name, value_type, list_to_extend, exclude):
3737
for dep in js['targets'][name]['deps']:
3838
if 'modules' in dep:
3939
skip = True
40-
for white_list in ['skshaper', 'skparagraph']:
41-
if white_list in dep:
40+
for include in ['skshaper', 'skparagraph']:
41+
if include in dep:
4242
skip = False
4343
if skip:
4444
continue # Modules require special handling -- skip for now.

infra/bots/gen_tasks_logic/nano_flags.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ func (b *taskBuilder) nanobenchFlags(doUpload bool) {
289289
}
290290

291291
if doUpload {
292-
keysBlacklist := map[string]bool{
292+
keysExclude := map[string]bool{
293293
"configuration": true,
294294
"role": true,
295295
"test_filter": true,
@@ -301,7 +301,7 @@ func (b *taskBuilder) nanobenchFlags(doUpload bool) {
301301
sort.Strings(keys)
302302
args = append(args, "--key")
303303
for _, k := range keys {
304-
if !keysBlacklist[k] {
304+
if !keysExclude[k] {
305305
args = append(args, k, b.parts[k])
306306
}
307307
}

infra/bots/recipes/perf_skottiewasm_lottieweb.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
'vars',
2727
]
2828

29-
LOTTIE_WEB_BLACKLIST = [
29+
LOTTIE_WEB_EXCLUDE = [
3030
# See https://bugs.chromium.org/p/skia/issues/detail?id=9187#c4
3131
'lottiefiles.com - Progress Success.json',
3232
# Fails with "val2 is not defined".
@@ -44,7 +44,7 @@
4444
'stacking.json',
4545
]
4646

47-
SKOTTIE_WASM_BLACKLIST = [
47+
SKOTTIE_WASM_EXCLUDE = [
4848
# Trace file has majority main_frame_aborted terminations in it and < 25
4949
# occurrences of submitted_frame + missed_frame.
5050
# Below descriptions are added from fmalita@'s comments in
@@ -73,7 +73,7 @@
7373
]
7474

7575
# These files work in SVG but not in Canvas.
76-
LOTTIE_WEB_CANVAS_BLACKLIST = LOTTIE_WEB_BLACKLIST + [
76+
LOTTIE_WEB_CANVAS_EXCLUDE = LOTTIE_WEB_EXCLUDE + [
7777
'Hello World.json',
7878
'interactive_menu.json',
7979
'Name.json',
@@ -104,19 +104,19 @@ def RunSteps(api):
104104
'--canvaskit_wasm', canvaskit_wasm_path,
105105
]
106106
lottie_files = [x for x in lottie_files
107-
if api.path.basename(x) not in SKOTTIE_WASM_BLACKLIST]
107+
if api.path.basename(x) not in SKOTTIE_WASM_EXCLUDE]
108108
elif 'LottieWeb' in buildername:
109109
source_type = 'lottie-web'
110110
renderer = 'lottie-web'
111111
if 'Canvas' in buildername:
112112
backend = 'canvas'
113113
lottie_files = [
114114
x for x in lottie_files
115-
if api.path.basename(x) not in LOTTIE_WEB_CANVAS_BLACKLIST]
115+
if api.path.basename(x) not in LOTTIE_WEB_CANVAS_EXCLUDE]
116116
else:
117117
backend = 'svg'
118118
lottie_files = [x for x in lottie_files
119-
if api.path.basename(x) not in LOTTIE_WEB_BLACKLIST]
119+
if api.path.basename(x) not in LOTTIE_WEB_EXCLUDE]
120120

121121
perf_app_dir = checkout_root.join('skia', 'tools', 'lottie-web-perf')
122122
lottie_web_js_path = perf_app_dir.join('lottie-web-perf.js')

src/core/SkFuzzLogging.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// Utilities for Skia's fuzzer
1212

1313
// When SK_FUZZ_LOGGING is defined SkDebugfs relevant to image filter fuzzing
14-
// will be enabled. This allows the filter fuzzing code to white list fuzzer
14+
// will be enabled. This allows the filter fuzzing code to include fuzzer
1515
// failures based on the output logs.
1616
// Define this flag in your SkUserConfig.h or in your Make/Build system.
1717
#ifdef SK_FUZZ_LOGGING

0 commit comments

Comments
 (0)